public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Joao Pedro De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Dave Page <[email protected]>
Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
Date: Tue, 20 Mar 2018 13:21:02 +0530
Message-ID: <CANxoLDecQruspbc0dyw6ARNAM6DYJF5pC_0UJPqUzAM9spQHYg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozK4FeKyugzWNc2aRC1cMONiQMbFgus7Aj=7U28CaKV=Q@mail.gmail.com>
References: <CAE+jjakOhMJBMqsUaQuL9w4an0V4Q4nvY51K3GqWzm8jbj9cog@mail.gmail.com>
	<CA+OCxowBzhOaJf1_w1gPhOR4TH3bdtKBsdqETAqSwK0n2GWezg@mail.gmail.com>
	<CA+OCxoyT9yQU-ayjRa94UMaekGP7QhB3CNqaJ_A-j8t+4Jb4FA@mail.gmail.com>
	<CAE+jjam6bc4HeZgFbRayxXOJVft6J7s=Xb7M8i54mX7tNCp08Q@mail.gmail.com>
	<CA+OCxozK4FeKyugzWNc2aRC1cMONiQMbFgus7Aj=7U28CaKV=Q@mail.gmail.com>

--94eb2c12522415dba50567d35659
Content-Type: text/plain; charset="UTF-8"

Hi Joao

It seems that this fix broke the functionality of RM #2815. It is mentioned
in the RM what needs to be fixed now and I am currently working on it.
While fixing the issue following problem that I found

   - In "start_running_query.py" file, we need to remove check "if
conn.connected()"
   from "__execute_query" function as we required exception to be thrown while
   executing the query to identify the ConnectionLost.
   - In "execute_query.js" we have used *axios* to execute the query and in
   case of exception, object is different then normal javascript response
   object.
   - We call following functions when exception or error comes and send the
   "*<object>.response.data*" as parameter
      - wasConnectionLostToServer(): Check for the readyState parameter,
      which is not the part of "<object>.response.data".
      - extractErrorMessage(): Check for the "responseJSON" and "
      responseJSON.info", which is not the part of "<object>.response.data".
      - is_pga_login_required(): Check for the "responseJSON" and "
      responseJSON.info", which is not the part of "<object>.response.data".
      - is_new_transaction_required(): Check for the "responseJSON" and "
      responseJSON.info", which is not the part of "<object>.response.data".

view thread (19+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
  In-Reply-To: <CANxoLDecQruspbc0dyw6ARNAM6DYJF5pC_0UJPqUzAM9spQHYg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox