public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][Patch] - RM 4773 - [Accessibility] Provide Role to element to display the status
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][Patch] - RM 4773 - [Accessibility] Provide Role to element to display the status
@ 2019-12-02 05:58 Khushboo Vashi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Khushboo Vashi @ 2019-12-02 05:58 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
Please find the attached patch for RM #4773 - [Accessibility] Provide Role
to element to display the status.
- Added role="status" attribute to all the status messages.
Thanks,
Khushboo
Attachments:
[application/octet-stream] RM_4773.patch (4.4K, 3-RM_4773.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/static/js/node.js b/web/pgadmin/browser/static/js/node.js
index 90e4fb611..9d6af7375 100644
--- a/web/pgadmin/browser/static/js/node.js
+++ b/web/pgadmin/browser/static/js/node.js
@@ -1103,7 +1103,7 @@ define('pgadmin.browser.node', [
// Template function to create the status bar
var createStatusBar = function(location) {
- var statusBar = $('<div></div>').addClass(
+ var statusBar = $('<div role="status"></div>').addClass(
'pg-prop-status-bar'
).appendTo(j);
statusBar.css('visibility', 'hidden');
diff --git a/web/pgadmin/static/js/alertify.pgadmin.defaults.js b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
index 38dc436fb..78ffb2139 100644
--- a/web/pgadmin/static/js/alertify.pgadmin.defaults.js
+++ b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
@@ -127,7 +127,7 @@ define([
alertMessage = '\
<div class="media text-danger text-14">\
<div class="media-body media-middle">\
- <div class="alert-text">' + promptmsg + '</div><br/>\
+ <div class="alert-text" role="status">' + promptmsg + '</div><br/>\
<div class="alert-text">' + gettext('Click for details.') + '</div>\
</div>\
</div>';
@@ -172,7 +172,7 @@ define([
var alertMessage = '\
<div class="media text-danger text-14">\
<div class="media-body media-middle">\
- <div class="alert-text">' + gettext('INTERNAL SERVER ERROR') + '</div><br/>\
+ <div class="alert-text" role="status">' + gettext('INTERNAL SERVER ERROR') + '</div><br/>\
<div class="alert-text">' + gettext('Click for details.') + '</div>\
</div>\
</div>';
@@ -422,7 +422,7 @@ define([
<div class="pr-2">
<i class="fa fa-check text-success" aria-hidden="true"></i>
</div>
- <div class="text-body">${message}</div>
+ <div class="text-body" role="status">${message}</div>
</div>`;
return alertify.orig_success(alertMessage, timeout, callback);
},
@@ -432,7 +432,7 @@ define([
<div class="pr-2">
<i class="fa fa-exclamation-triangle text-danger" aria-hidden="true"></i>
</div>
- <div class="text-body">${message}</div>
+ <div class="text-body" role="status">${message}</div>
</div>`;
return alertify.orig_error(alertMessage, timeout, callback);
},
@@ -442,7 +442,7 @@ define([
<div class="mr-3">
<i class="fa fa-info text-primary" aria-hidden="true"></i>
</div>
- <div class="text-body">${message}</div>
+ <div class="text-body" role="status">${message}</div>
</div>`;
var alert = alertify.notify(alertMessage, timeout);
return alert;
diff --git a/web/pgadmin/static/js/sqleditor/filter_dialog.js b/web/pgadmin/static/js/sqleditor/filter_dialog.js
index f5662ea5c..92ee6e0aa 100644
--- a/web/pgadmin/static/js/sqleditor/filter_dialog.js
+++ b/web/pgadmin/static/js/sqleditor/filter_dialog.js
@@ -128,7 +128,7 @@ let FilterDialog = {
' <div class="pr-2"> ' +
' <i class="fa fa-exclamation-triangle text-danger" aria-hidden="true"></i> ' +
' </div> ' +
- ' <div class="alert-text"></div> ' +
+ ' <div class="alert-text" role="status"></div> ' +
' </div> ' +
' </div> ' +
'</div>').appendTo($container);
diff --git a/web/pgadmin/tools/user_management/static/js/user_management.js b/web/pgadmin/tools/user_management/static/js/user_management.js
index 2423c5c61..ea65ca7ac 100644
--- a/web/pgadmin/tools/user_management/static/js/user_management.js
+++ b/web/pgadmin/tools/user_management/static/js/user_management.js
@@ -636,7 +636,7 @@ define([
' <div class="pr-2"> ',
' <i class="fa fa-exclamation-triangle text-danger" aria-hidden="true"></i> ',
' </div> ',
- ' <div class="alert-text"></div> ',
+ ' <div class="alert-text" role="status></div> ',
' <div class="ml-auto close-error-bar"> ',
' <a class="close-error fa fa-times text-danger"></a> ',
' </div> ',
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][Patch] - RM 4773 - [Accessibility] Provide Role to element to display the status
@ 2019-12-02 08:55 Akshay Joshi <[email protected]>
parent: Khushboo Vashi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2019-12-02 08:55 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Mon, Dec 2, 2019 at 11:28 AM Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> Please find the attached patch for RM #4773 - [Accessibility] Provide
> Role to element to display the status.
>
> - Added role="status" attribute to all the status messages.
>
> Thanks,
> Khushboo
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-12-02 08:55 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 05:58 [pgAdmin4][Patch] - RM 4773 - [Accessibility] Provide Role to element to display the status Khushboo Vashi <[email protected]>
2019-12-02 08:55 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox