public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration
@ 2020-04-13 05:18 Neel Patel <[email protected]>
2020-04-13 08:35 ` Re: [pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Neel Patel @ 2020-04-13 05:18 UTC (permalink / raw)
To: pgadmin-hackers <[email protected]>
Hi,
Please find an attached patch to fix the issue in the configuration window
in runtime where control where not auto resize and visible when the user
resizes the dialog.
Do review it and let me know for comments.
Thanks,
Neel Patel
Attachments:
[application/x-patch] RM_4864_v1.patch (14.0K, 3-RM_4864_v1.patch)
download | inline diff:
diff --git a/runtime/ConfigWindow.ui b/runtime/ConfigWindow.ui
index fbdddfc2d..12770160a 100644
--- a/runtime/ConfigWindow.ui
+++ b/runtime/ConfigWindow.ui
@@ -6,7 +6,7 @@
<rect>
<x>0</x>
<y>0</y>
- <width>731</width>
+ <width>975</width>
<height>398</height>
</rect>
</property>
@@ -18,7 +18,7 @@
</property>
<property name="minimumSize">
<size>
- <width>625</width>
+ <width>975</width>
<height>300</height>
</size>
</property>
@@ -51,7 +51,7 @@
</property>
<property name="maximumSize">
<size>
- <width>589</width>
+ <width>16777215</width>
<height>16777215</height>
</size>
</property>
@@ -61,6 +61,9 @@
<property name="wordWrap">
<bool>true</bool>
</property>
+ <property name="margin">
+ <number>4</number>
+ </property>
</widget>
</item>
<item>
@@ -123,6 +126,9 @@
<property name="orientation">
<enum>Qt::Vertical</enum>
</property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Fixed</enum>
+ </property>
<property name="sizeHint" stdset="0">
<size>
<width>20</width>
@@ -249,6 +255,9 @@
<property name="orientation">
<enum>Qt::Vertical</enum>
</property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Fixed</enum>
+ </property>
<property name="sizeHint" stdset="0">
<size>
<width>20</width>
@@ -304,6 +313,19 @@
</item>
</layout>
</item>
+ <item>
+ <spacer name="verticalSpacer_6">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>40</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
</layout>
</item>
</layout>
@@ -312,21 +334,11 @@
<attribute name="title">
<string>Python</string>
</attribute>
- <layout class="QVBoxLayout" name="verticalLayout_5">
- <item>
- <layout class="QVBoxLayout" name="verticalLayout_4">
+ <layout class="QGridLayout" name="gridLayout">
+ <item row="0" column="0">
+ <layout class="QVBoxLayout" name="verticalLayout_7">
<item>
- <widget class="QLabel" name="label_4">
- <property name="text">
- <string>The options below are intended for expert users only, and may not behave as expected as they modify fixed search paths and are not alternate values. Modify with care!</string>
- </property>
- <property name="wordWrap">
- <bool>true</bool>
- </property>
- </widget>
- </item>
- <item>
- <spacer name="verticalSpacer_3">
+ <spacer name="verticalSpacer_7">
<property name="orientation">
<enum>Qt::Vertical</enum>
</property>
@@ -336,89 +348,240 @@
<property name="sizeHint" stdset="0">
<size>
<width>20</width>
- <height>5</height>
+ <height>13</height>
</size>
</property>
</spacer>
</item>
<item>
- <layout class="QGridLayout" name="gridLayout">
- <item row="3" column="1">
- <spacer name="verticalSpacer_5">
- <property name="orientation">
- <enum>Qt::Vertical</enum>
- </property>
- <property name="sizeType">
- <enum>QSizePolicy::Expanding</enum>
+ <layout class="QHBoxLayout" name="horizontalLayout_7">
+ <item>
+ <widget class="QLabel" name="label_4">
+ <property name="sizePolicy">
+ <sizepolicy hsizetype="Expanding" vsizetype="Preferred">
+ <horstretch>0</horstretch>
+ <verstretch>0</verstretch>
+ </sizepolicy>
</property>
- <property name="sizeHint" stdset="0">
+ <property name="minimumSize">
<size>
- <width>20</width>
- <height>60</height>
+ <width>450</width>
+ <height>28</height>
</size>
</property>
- </spacer>
- </item>
- <item row="0" column="0">
- <widget class="QLabel" name="pythonPathLabel">
- <property name="text">
- <string>Python Path</string>
- </property>
- </widget>
- </item>
- <item row="6" column="1">
- <widget class="QLabel" name="label_2">
<property name="text">
- <string>Enter the path to the directory containing pgAdmin.py if desired.</string>
+ <string>The options below are intended for expert users only, and may not behave as expected as they modify fixed search paths and are not alternate values. Modify with care!</string>
</property>
- </widget>
- </item>
- <item row="0" column="1">
- <widget class="QLineEdit" name="pythonPathLineEdit">
- <property name="placeholderText">
- <string>/usr/pgadmin4/lib/python2.7;/usr/pgadmin4/lib/python2.7/site-packages</string>
+ <property name="wordWrap">
+ <bool>true</bool>
</property>
</widget>
</item>
- <item row="5" column="1">
- <widget class="QLineEdit" name="applicationPathLineEdit">
- <property name="placeholderText">
- <string>/usr/pgadmin4/web</string>
- </property>
- </widget>
+ </layout>
+ </item>
+ <item>
+ <spacer name="verticalSpacer_3">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Fixed</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>17</width>
+ <height>13</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ <item>
+ <layout class="QHBoxLayout" name="horizontalLayout_6">
+ <item>
+ <layout class="QVBoxLayout" name="verticalLayout_6">
+ <item>
+ <widget class="QLabel" name="pythonPathLabel">
+ <property name="minimumSize">
+ <size>
+ <width>50</width>
+ <height>20</height>
+ </size>
+ </property>
+ <property name="layoutDirection">
+ <enum>Qt::LeftToRight</enum>
+ </property>
+ <property name="text">
+ <string>Python Path</string>
+ </property>
+ <property name="scaledContents">
+ <bool>true</bool>
+ </property>
+ <property name="margin">
+ <number>0</number>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <spacer name="verticalSpacer_9">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Fixed</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>40</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ </layout>
</item>
- <item row="5" column="0">
- <widget class="QLabel" name="applicationPathLabel">
- <property name="text">
- <string>Application Path</string>
- </property>
- </widget>
+ <item>
+ <layout class="QVBoxLayout" name="verticalLayout_5">
+ <item>
+ <widget class="QLineEdit" name="pythonPathLineEdit">
+ <property name="placeholderText">
+ <string>/usr/pgadmin4/lib/python2.7;/usr/pgadmin4/lib/python2.7/site-packages</string>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <widget class="QLabel" name="label">
+ <property name="sizePolicy">
+ <sizepolicy hsizetype="Expanding" vsizetype="Preferred">
+ <horstretch>0</horstretch>
+ <verstretch>0</verstretch>
+ </sizepolicy>
+ </property>
+ <property name="minimumSize">
+ <size>
+ <width>300</width>
+ <height>20</height>
+ </size>
+ </property>
+ <property name="text">
+ <string>Enter a PYTHONPATH if desired. Path elements should be semi-colon delimited.</string>
+ </property>
+ <property name="textFormat">
+ <enum>Qt::AutoText</enum>
+ </property>
+ <property name="wordWrap">
+ <bool>true</bool>
+ </property>
+ </widget>
+ </item>
+ </layout>
</item>
- <item row="2" column="1">
- <widget class="QLabel" name="label">
- <property name="text">
- <string>Enter a PYTHONPATH if desired. Path elements should be semi-colon delimited.</string>
- </property>
- <property name="wordWrap">
- <bool>true</bool>
- </property>
- </widget>
+ </layout>
+ </item>
+ <item>
+ <spacer name="verticalSpacer_2">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Fixed</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>13</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ <item>
+ <layout class="QHBoxLayout" name="horizontalLayout_3">
+ <item>
+ <layout class="QVBoxLayout" name="verticalLayout_4">
+ <item>
+ <widget class="QLabel" name="applicationPathLabel">
+ <property name="text">
+ <string>Application Path</string>
+ </property>
+ <property name="textFormat">
+ <enum>Qt::PlainText</enum>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <spacer name="verticalSpacer_5">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Fixed</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>40</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ </layout>
</item>
- <item row="7" column="1">
- <spacer name="verticalSpacer_2">
- <property name="orientation">
- <enum>Qt::Vertical</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>20</width>
- <height>40</height>
- </size>
- </property>
- </spacer>
+ <item>
+ <layout class="QVBoxLayout" name="verticalLayout_3">
+ <item>
+ <widget class="QLineEdit" name="applicationPathLineEdit">
+ <property name="placeholderText">
+ <string>/usr/pgadmin4/web</string>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <widget class="QLabel" name="label_2">
+ <property name="sizePolicy">
+ <sizepolicy hsizetype="Expanding" vsizetype="Fixed">
+ <horstretch>0</horstretch>
+ <verstretch>0</verstretch>
+ </sizepolicy>
+ </property>
+ <property name="minimumSize">
+ <size>
+ <width>300</width>
+ <height>20</height>
+ </size>
+ </property>
+ <property name="text">
+ <string>Enter the path to the directory containing pgAdmin.py if desired.</string>
+ </property>
+ <property name="scaledContents">
+ <bool>false</bool>
+ </property>
+ <property name="alignment">
+ <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignVCenter</set>
+ </property>
+ <property name="wordWrap">
+ <bool>true</bool>
+ </property>
+ </widget>
+ </item>
+ </layout>
</item>
</layout>
</item>
+ <item>
+ <spacer name="verticalSpacer_8">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Expanding</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>60</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
</layout>
</item>
</layout>
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration
2020-04-13 05:18 [pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration Neel Patel <[email protected]>
@ 2020-04-13 08:35 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2020-04-13 08:35 UTC (permalink / raw)
To: Neel Patel <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Thanks, patch applied.
On Mon, Apr 13, 2020 at 10:48 AM Neel Patel <[email protected]>
wrote:
> Hi,
>
> Please find an attached patch to fix the issue in the configuration window
> in runtime where control where not auto resize and visible when the user
> resizes the dialog.
>
> Do review it and let me know for comments.
>
> Thanks,
> Neel Patel
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-04-13 08:35 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 05:18 [pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration Neel Patel <[email protected]>
2020-04-13 08:35 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox