public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions
Date: Mon, 28 Jan 2019 16:38:22 +0530
Message-ID: <CANxoLDeqn8TwWfJdwQ7ZGHw_jC+hT-DncaszSMZDTkOnJ_xqLA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQhaYR_NvPa_CKdd-7PoWQspCQFODCZj2AuLfU4qE39tA@mail.gmail.com>
References: <CAKKotZTf=gmr3F6QvgbFfi1DEFZCAtB17Ai9UZD4fBHJqyLCaA@mail.gmail.com>
<CANxoLDckA6XT51xibDmSdt0Jcv_suyAv1G7TBLYLJw6cVxj4+w@mail.gmail.com>
<CAKKotZQhaYR_NvPa_CKdd-7PoWQspCQFODCZj2AuLfU4qE39tA@mail.gmail.com>
Hi Murtuza
Here are my review comments:
- Exact error should be logged in the log file and on GUI we should show
message like "Unable to fetch <function/table> object".
- Message should be shown in the status bar.
- If there is an error to fetch one kind of object, we should show other
objects.
On Mon, Jan 28, 2019 at 2:49 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA minor patch, To display an error on UI when there is a backend error
> for the grant wizard request.
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks patch applied.
>>
>> On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where EPAS DB instance running with
>>> *no-redwood-compat* mode fails to list down functions objects in grant
>>> wizard due to 'char' -> 'int' type cast error.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions
In-Reply-To: <CANxoLDeqn8TwWfJdwQ7ZGHw_jC+hT-DncaszSMZDTkOnJ_xqLA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox