public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
Date: Thu, 18 May 2017 15:07:18 +0530
Message-ID: <CANxoLDeqzDysu_e2HS2LQk89Xma0V2rtkUhEbmmunhTth9LTpA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozoOV5M2SkBvw3S7Kif0RhyVK5cZ9O=0WZZ+MGfZXMCPw@mail.gmail.com>
References: <CANxoLDczJ5ckfbMGM8i3MxNp+VB0D5ABrH1s7D_xGUJxZLD_4Q@mail.gmail.com>
<CA+OCxozoOV5M2SkBvw3S7Kif0RhyVK5cZ9O=0WZZ+MGfZXMCPw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Thu, May 18, 2017 at 3:00 PM, Dave Page <[email protected]> wrote:
> Hi
>
> Please see the discussion here: https://redmine.postgresql.org/issues/2308
>
> Would moving to the client-side translation mechanism help here? We need
> to do that anyway - and it's been added since the previous discussion.
>
OK, at least we should checked-in code for showing title of the
confirmation dialog for "Truncate".
>
> On Thu, May 18, 2017 at 10:17 AM, Akshay Joshi <
> [email protected]> wrote:
>
>> Hi All
>>
>> I have found one issue where table name is not displaying in the confirmation
>> dialog when user click on "Reset Statistics" and "Truncate/Truncate
>> cascade". Confirmation dialog shows below message:
>>
>> - Are you sure you want to truncate table {}?
>> - Are you sure you want to reset the statistics for table {}?
>>
>> Also header is missing for "Truncate/Truncate cascade" confirmation
>> dialog. Attached is the patch file to fix that above. Please review it.
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
In-Reply-To: <CANxoLDeqzDysu_e2HS2LQk89Xma0V2rtkUhEbmmunhTth9LTpA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox