public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Neel Patel <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RM 4463 - RESQL test cases for domain node
Date: Wed, 21 Aug 2019 16:54:40 +0530
Message-ID: <CANxoLDf66mQREt-bdWm2=w_a1cDjG10=FykE90SPnc=t7p=yng@mail.gmail.com> (raw)
In-Reply-To: <CACCA4P3Enjd+gubO8gWGn-sKfrVotz29gU5w_DZqPVMAPt7Bag@mail.gmail.com>
References: <CACCA4P3XMhijv57k0xmfNWCRh65O5Qdq+gtgpOZ3-_Ma2jTzqw@mail.gmail.com>
	<CA+OCxoxX7K+F++vF6X3K3JP7+NVeEXOR+LSK0FV0hbfwRPyofA@mail.gmail.com>
	<CACCA4P3Enjd+gubO8gWGn-sKfrVotz29gU5w_DZqPVMAPt7Bag@mail.gmail.com>

Hi Neel

MSQL test case for *create* was not running before. In my last patch I have
fixed that. Applying your patch on latest code not working can you please
fix that and re-send the patch.

On Wed, Aug 21, 2019 at 2:33 PM Neel Patel <[email protected]>
wrote:

> Hi,
>
> Please find attached patch that will add more resql test cases for domain
> node.
>
>    - Covered test cases for Length, Precision and Collation.
>    - Also added msql test cases.
>
> While writing resql test cases for domain node, I found one more issue
> RM-4644 <https://redmine.postgresql.org/issues/4644;. I am sending
> separate patch for the same.
>
> Thanks,
> Neel Patel
>
> On Fri, Jul 12, 2019 at 7:10 PM Dave Page <[email protected]> wrote:
>
>> Thanks, applied.
>>
>> On Fri, Jul 12, 2019 at 12:31 PM Neel Patel <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch for reverse engineering test cases for domain
>>> node ( RM #4463 )
>>> Do review it and let me know for comments.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: RM 4463 - RESQL test cases for domain node
  In-Reply-To: <CANxoLDf66mQREt-bdWm2=w_a1cDjG10=FykE90SPnc=t7p=yng@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox