public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Rahul Shirsat <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View
Date: Mon, 25 Nov 2019 11:11:40 +0530
Message-ID: <CANxoLDf8qZOKk_UcL9FLpyK1rwq6XC+=zVg32S_+n4MUtahB7w@mail.gmail.com> (raw)
In-Reply-To: <CAKtn9dNz1ozbJWzJw_qVLx3QAxcNSjCCJWqB8HW3Qn5Hooz-pA@mail.gmail.com>
References: <CAKtn9dOLhxuNmtPbBvbvDq29YFQ48DTXhv5QGjav7KG8Eht2SA@mail.gmail.com>
<CANxoLDc9-1X-cZo0FSzNhBG9m2s-HO0rKzsR5RS3kYPmBBgwow@mail.gmail.com>
<CANxoLDeCm9b2u=G5+eJU6NJQDpa0AJGFzmRw6iTfVf6ZAHBXMQ@mail.gmail.com>
<CAKtn9dNz1ozbJWzJw_qVLx3QAxcNSjCCJWqB8HW3Qn5Hooz-pA@mail.gmail.com>
Thanks, patch applied.
On Sat, Nov 23, 2019 at 12:37 AM Rahul Shirsat <
[email protected]> wrote:
> Akshay,
>
> Please find the correction done in this updated patch based on your review
> comments.
>
> Regards,
> Rahul Shirsat.
>
> On Thu, Nov 21, 2019 at 1:08 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Rahul
>>
>> Some more review comments:
>>
>> - Don't create new file test_view.json as I tested and committed the
>> old code.
>> - Remove hardcoded "oid: 17869" from JSON file.
>> - MSQL endpoints and file name missing in some test cases.
>> - Cover all the controls in create and alter as much as possible.
>>
>>
>> On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Rahul
>>>
>>> Test cases failing on all EPAS servers. Please fix and send the patch
>>> again.
>>>
>>> On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> I have attached the patch for RE-SQL/MSQL test cases for View as well
>>>> as Materialized View.
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View
In-Reply-To: <CANxoLDf8qZOKk_UcL9FLpyK1rwq6XC+=zVg32S_+n4MUtahB7w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox