public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - SonarQube Fixes
Date: Tue, 4 Aug 2020 12:10:17 +0530
Message-ID: <CANxoLDf93wWrt8W94wVhtz1mzFJJe2Hb8UNDPmL+maxwnpNcrQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELd+8ump0kQ-UHeN9szfefVh-QG0HvGSFZif47ryPoETrw@mail.gmail.com>
References: <CAFOhELd+8ump0kQ-UHeN9szfefVh-QG0HvGSFZif47ryPoETrw@mail.gmail.com>
Hi Khushboo
As per offline discussion, multiple developers declaring the constant for
the same string and error messages. To avoid that only one developer should
work on this task.
Suggestions:
- We should have a common class for Constants (which are not module
specific).
- For module specific constants we should not declare them as Global
variables if possible declare them as the Class variable.
- For common error messages(if any) we can define functions in
PGChildNodeView.
Please incorporate the changes send by Yogesh.
On Mon, Aug 3, 2020 at 1:36 PM Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> Please find the attached patch to fix the sonarqube code smells having the
> rule "String literals should not be duplicated".
>
> Thanks,
> Khushboo
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch] - SonarQube Fixes
In-Reply-To: <CANxoLDf93wWrt8W94wVhtz1mzFJJe2Hb8UNDPmL+maxwnpNcrQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox