public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Pradip Parkale <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.
Date: Thu, 1 Apr 2021 12:14:56 +0530
Message-ID: <CANxoLDf9OxBbMB7TQvyNtwNDn5SjyZUNYNCDkgX34DL9S4Mrmw@mail.gmail.com> (raw)
In-Reply-To: <CAJ9T6SvVw-Q1M-baSPc6tzvoO7q+em39Pq=bzeb869gEDMLM4Q@mail.gmail.com>
References: <CAJ9T6SuRougj0rUJai0BdSRY17kPPCi7w0cbEv6DSLeEn2e0mw@mail.gmail.com>
	<CA+OCxoxHneaUCAyhTPa1MfiuDTr6JhUfHzyaE4NBt-y1FMOXaA@mail.gmail.com>
	<CAJ9T6SvVw-Q1M-baSPc6tzvoO7q+em39Pq=bzeb869gEDMLM4Q@mail.gmail.com>

Thanks, patch applied.

On Thu, Apr 1, 2021 at 11:40 AM Pradip Parkale <
[email protected]> wrote:

> Hi Hackers,
>
> Please find the updated patch with the change mentioned by Dave.
>
> On Wed, Mar 31, 2021 at 7:53 PM Dave Page <[email protected]> wrote:
>
>> Thanks Pradip.
>>
>> Before this is committed, let's change this:
>>
>> gettext('Current trasaction is not commited because server is
>> disconnected.'),
>>
>> to:
>>
>> gettext('The current transaction has been rolled back because the server
>> was disconnected.'),
>>
>> On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>> Please find the attached patch for #5519. Updated the existing
>>> confirmation message and also added a new confirmation dialog before
>>> closing the query tool if the server is disconnected.
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


view thread (4+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.
  In-Reply-To: <CANxoLDf9OxBbMB7TQvyNtwNDn5SjyZUNYNCDkgX34DL9S4Mrmw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox