public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4421] Inno setup script version compare fix
Date: Tue, 2 Jul 2019 14:59:12 +0530
Message-ID: <CANxoLDf=9Ra7MsZBpVmDHNBUc4DJvuATBozbw8qeuCaGtXZaSQ@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_k6dPTtdWpQFNJ0+nYUP0nafzJS4kn+WXXmQ4xyPTHemg@mail.gmail.com>
References: <CAM9w-_mnD3MQBMLZdY9oKwSsu6fiwWUFY9ZZob6fPUfiormy1A@mail.gmail.com>
<CANxoLDdjtQK1sqmAhE4JsjdiM_5rvZnF31Po8NeDfGbmWyA8Aw@mail.gmail.com>
<CAM9w-_k6dPTtdWpQFNJ0+nYUP0nafzJS4kn+WXXmQ4xyPTHemg@mail.gmail.com>
Thanks patch applied.
On Tue, Jul 2, 2019 at 2:51 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the updated patch. Instead of float comparison, string
> comparison is done now with the help of a nice article here -
> http://www.arvydas.co.uk/2015/04/compare-version-strings-with-innosetup/
>
> Kindly review.
>
> On Tue, Jul 2, 2019 at 2:34 PM Akshay Joshi <[email protected]>
> wrote:
>
>> Hi Aditya
>>
>> I have asked Paresh to review the patch, he has given some review
>> comments. Please fix those and the updated patch asap.
>>
>> On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix a potential issue where version compare
>>> while upgrading will be incorrect. Currently, it is comparing strings. So
>>> while comparing '4.9' and '4.10' it will consider '4.9' as greater.
>>> The patch will convert the values to float and compare.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4421] Inno setup script version compare fix
In-Reply-To: <CANxoLDf=9Ra7MsZBpVmDHNBUc4DJvuATBozbw8qeuCaGtXZaSQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox