public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Yogesh Mahajan <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment
Date: Fri, 11 Mar 2022 14:12:48 +0530
Message-ID: <CANxoLDfMznVCXH-gV9TVCs+W5tUFag2SeMB+qrcxM3ZTfC78iA@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELePip50E-859YN+BAuJLL8C=6JPyfeomrX+82GGspUxNA@mail.gmail.com>
References: <CAFOhELeN2ewo5zA79e9dRAoCQEgbUfQ+2+SuT8z65Vn7XMtcpQ@mail.gmail.com>
<CAMa=N=NUWfQKf15jU0dJkPD=RkJHoeF--Hq7M4L5bCE0jXbO_w@mail.gmail.com>
<CANxoLDf_ZfeECUA1XQcAJOPHs1E7eWC7=bThdAbGdqxxTotK2w@mail.gmail.com>
<CAFOhELePip50E-859YN+BAuJLL8C=6JPyfeomrX+82GGspUxNA@mail.gmail.com>
Isn't it possible to define it at a common location? These types of
duplicate code are error-prone since sometimes we fix an issue at one place
and forget to fix it at another.
On Fri, Mar 11, 2022 at 11:56 AM Khushboo Vashi <
[email protected]> wrote:
> One is for pgacloud standalone code for background process and one for
> pgadmin module.
>
> On Fri, 11 Mar 2022, 10:11 Akshay Joshi, <[email protected]>
> wrote:
>
>> Hi Khushboo
>>
>> Why there are two identical functions (def get_my_ip) in two different
>> files, can you please make it generic in one place only and send the patch.
>>
>> On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Patch looks fine. IP Addresses are prefixed by 32 and 128 for IPv4 and
>>> IPv6 respectively.
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix the default Public IP range issue
>>>> in AWS deployment.
>>>>
>>>> @Yogesh Mahajan <[email protected]>, please test.
>>>>
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment
In-Reply-To: <CANxoLDfMznVCXH-gV9TVCs+W5tUFag2SeMB+qrcxM3ZTfC78iA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox