public inbox for [email protected]
help / color / mirror / Atom feed[patch][pgAdmin] RM6859 Properties panel is not updated when any object is added from the browser tree
2+ messages / 2 participants
[nested] [flat]
* [patch][pgAdmin] RM6859 Properties panel is not updated when any object is added from the browser tree
@ 2021-10-26 08:43 Rahul Shirsat <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Shirsat @ 2021-10-26 08:43 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the attached patch which resolves the issue properties panel
updation.
This patch will have unique behaviour throughout, i.e. new node will be
selected on creation, instead of selecting the collection node.
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM6859.patch (844B, 3-RM6859.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/static/js/browser.js b/web/pgadmin/browser/static/js/browser.js
index 40fc14a8a..45f18cb93 100644
--- a/web/pgadmin/browser/static/js/browser.js
+++ b/web/pgadmin/browser/static/js/browser.js
@@ -1086,11 +1086,13 @@ define('pgadmin.browser', [
};
if (binarySearch()) {
- __ctx.t.before(i, _data).then(() => {
+ __ctx.t.before(i, _data).then((_item) => {
if (
__ctx.o && __ctx.o.success && typeof(__ctx.o.success) == 'function'
) {
__ctx.o.success.apply(__ctx.t, [i, _data]);
+ } else {
+ __ctx.t.select(_item);
}
}, () => {
console.warn('Failed to add before...', arguments);
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [patch][pgAdmin] RM6859 Properties panel is not updated when any object is added from the browser tree
@ 2021-10-27 05:36 Akshay Joshi <[email protected]>
parent: Rahul Shirsat <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2021-10-27 05:36 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Thanks, the patch applied.
On Tue, Oct 26, 2021 at 2:14 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached patch which resolves the issue properties panel
> updation.
>
> This patch will have unique behaviour throughout, i.e. new node will be
> selected on creation, instead of selecting the collection node.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-10-27 05:36 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 08:43 [patch][pgAdmin] RM6859 Properties panel is not updated when any object is added from the browser tree Rahul Shirsat <[email protected]>
2021-10-27 05:36 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox