public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Date: Tue, 22 Sep 2020 14:56:29 +0530
Message-ID: <CANxoLDfP08OdaHLPjM8uyUoGuYGwi7fCR3sa9rJTMb+jAnTqAQ@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mwdCFVfy16jgP7CGA5LGTDCnaJjsG19SKeVymmeGbS8Q@mail.gmail.com>
References: <CAM9w-_mwdCFVfy16jgP7CGA5LGTDCnaJjsG19SKeVymmeGbS8Q@mail.gmail.com>

Hi Aditya

The patch fixes only 1 code smell and introduce 1 new. Please fix those and
resend the patch.

On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached path will reduce the cognitive complexity as below:web/pgadmin/misc/file_manager/__init__.py
> 40 to 15; 43 to 15
>
> Please review.
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity
  In-Reply-To: <CANxoLDfP08OdaHLPjM8uyUoGuYGwi7fCR3sa9rJTMb+jAnTqAQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox