public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group
7+ messages / 3 participants
[nested] [flat]
* [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group
@ 2019-01-15 05:19 Aditya Toshniwal <[email protected]>
2019-01-15 12:54 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Akshay Joshi <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Aditya Toshniwal @ 2019-01-15 05:19 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is a tiny patch to fix long name display in dialogs.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachments:
[application/octet-stream] RM3695.patch (492B, 3-RM3695.patch)
download | inline diff:
diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss b/web/pgadmin/static/scss/_alertify.overrides.scss
index 235c9fdb..4979735f 100644
--- a/web/pgadmin/static/scss/_alertify.overrides.scss
+++ b/web/pgadmin/static/scss/_alertify.overrides.scss
@@ -50,6 +50,8 @@
.ajs-body .ajs-content {
top: $title-height !important;
bottom: $footer-height-calc !important;
+ word-break: break-word;
+ word-wrap: break-word;
}
/* Removes padding from alertify footer */
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group
2019-01-15 05:19 [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
@ 2019-01-15 12:54 ` Akshay Joshi <[email protected]>
2019-01-18 09:58 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Akshay Joshi @ 2019-01-15 12:54 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers
Thanks patch applied.
On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is a tiny patch to fix long name display in dialogs.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group
2019-01-15 05:19 [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-15 12:54 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Akshay Joshi <[email protected]>
@ 2019-01-18 09:58 ` Aditya Toshniwal <[email protected]>
2019-01-24 14:05 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Dave Page <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Aditya Toshniwal @ 2019-01-18 09:58 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
Hi Hackers,
Attached is the revised patch. The previous patch may affect changes at
unwanted places.
The revised patch has limited scope and will affect only where required.
Kindly review.
On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <[email protected]>
wrote:
> Thanks patch applied.
>
> On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is a tiny patch to fix long name display in dialogs.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachments:
[application/octet-stream] RM3695.revised.patch (1.1K, 3-RM3695.revised.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/alertify.pgadmin.defaults.js b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
index 0e890873..012c728a 100644
--- a/web/pgadmin/static/js/alertify.pgadmin.defaults.js
+++ b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
@@ -429,6 +429,7 @@ define([
onshow:function() {
$(this.elements.commands.close).attr('title', gettext('Close'));
$(this.elements.commands.maximize).attr('title', gettext('Maximize'));
+ $(this.elements.content).addClass('ajs-wrap-text');
},
reverseButtons: true,
});
diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss b/web/pgadmin/static/scss/_alertify.overrides.scss
index b856e0b1..523d55ba 100644
--- a/web/pgadmin/static/scss/_alertify.overrides.scss
+++ b/web/pgadmin/static/scss/_alertify.overrides.scss
@@ -53,10 +53,11 @@
}
.ajs-body .ajs-content {
bottom: $footer-height-calc !important;
- word-break: break-word;
+ }
+ .ajs-wrap-text {
+ word-break: break-all;
word-wrap: break-word;
}
-
/* Removes padding from alertify footer */
.ajs-footer {
padding: 0;
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group
2019-01-15 05:19 [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-15 12:54 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Akshay Joshi <[email protected]>
2019-01-18 09:58 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
@ 2019-01-24 14:05 ` Dave Page <[email protected]>
2019-01-24 14:11 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Dave Page @ 2019-01-24 14:05 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Akshay Joshi <[email protected]>; pgadmin-hackers
Akshay,
Are you look into this?
Thanks.
On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the revised patch. The previous patch may affect changes at
> unwanted places.
> The revised patch has limited scope and will affect only where required.
>
> Kindly review.
>
>
> On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks patch applied.
>>
>> On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is a tiny patch to fix long name display in dialogs.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group
2019-01-15 05:19 [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-15 12:54 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Akshay Joshi <[email protected]>
2019-01-18 09:58 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-24 14:05 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Dave Page <[email protected]>
@ 2019-01-24 14:11 ` Aditya Toshniwal <[email protected]>
2019-01-24 14:14 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Dave Page <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Aditya Toshniwal @ 2019-01-24 14:11 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Akshay Joshi <[email protected]>; pgadmin-hackers
Hi Dave,
This patch is applied.
On Thu, Jan 24, 2019 at 7:36 PM Dave Page <[email protected]> wrote:
> Akshay,
>
> Are you look into this?
>
> Thanks.
>
> On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the revised patch. The previous patch may affect changes at
>> unwanted places.
>> The revised patch has limited scope and will affect only where required.
>>
>> Kindly review.
>>
>>
>> On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks patch applied.
>>>
>>> On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is a tiny patch to fix long name display in dialogs.
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>>> "Don't Complain about Heat, Plant a tree"
>>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group
2019-01-15 05:19 [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-15 12:54 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Akshay Joshi <[email protected]>
2019-01-18 09:58 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-24 14:05 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Dave Page <[email protected]>
2019-01-24 14:11 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
@ 2019-01-24 14:14 ` Dave Page <[email protected]>
2019-01-24 17:38 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Akshay Joshi <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Dave Page @ 2019-01-24 14:14 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Akshay Joshi <[email protected]>; pgadmin-hackers
On Thu, Jan 24, 2019 at 2:11 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Dave,
>
> This patch is applied.
>
OK. Akshay, can you please make sure you reply to the thread when you
commit a patch? Otherwise, others (like me) don't necessarily see to remove
it from our TODOs.
Thanks!
>
> On Thu, Jan 24, 2019 at 7:36 PM Dave Page <[email protected]> wrote:
>
>> Akshay,
>>
>> Are you look into this?
>>
>> Thanks.
>>
>> On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the revised patch. The previous patch may affect changes at
>>> unwanted places.
>>> The revised patch has limited scope and will affect only where required.
>>>
>>> Kindly review.
>>>
>>>
>>> On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Thanks patch applied.
>>>>
>>>> On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is a tiny patch to fix long name display in dialogs.
>>>>>
>>>>> --
>>>>> Thanks and Regards,
>>>>> Aditya Toshniwal
>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>>>> "Don't Complain about Heat, Plant a tree"
>>>>>
>>>>
>>>>
>>>> --
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect *
>>>>
>>>>
>>>>
>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group
2019-01-15 05:19 [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-15 12:54 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Akshay Joshi <[email protected]>
2019-01-18 09:58 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-24 14:05 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Dave Page <[email protected]>
2019-01-24 14:11 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-24 14:14 ` Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Dave Page <[email protected]>
@ 2019-01-24 17:38 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Akshay Joshi @ 2019-01-24 17:38 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers
On Thu, 24 Jan 2019, 19:44 Dave Page <[email protected] wrote:
>
>
> On Thu, Jan 24, 2019 at 2:11 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> This patch is applied.
>>
>
> OK. Akshay, can you please make sure you reply to the thread when you
> commit a patch? Otherwise, others (like me) don't necessarily see to remove
> it from our TODOs.
>
Sure Dave. Generally i did that don't know how i forgot this.
>
> Thanks!
>
>
>>
>> On Thu, Jan 24, 2019 at 7:36 PM Dave Page <[email protected]> wrote:
>>
>>> Akshay,
>>>
>>> Are you look into this?
>>>
>>> Thanks.
>>>
>>> On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the revised patch. The previous patch may affect changes at
>>>> unwanted places.
>>>> The revised patch has limited scope and will affect only where required.
>>>>
>>>> Kindly review.
>>>>
>>>>
>>>> On Tue, Jan 15, 2019 at 6:24 PM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Thanks patch applied.
>>>>>
>>>>> On Tue, Jan 15, 2019 at 10:50 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is a tiny patch to fix long name display in dialogs.
>>>>>>
>>>>>> --
>>>>>> Thanks and Regards,
>>>>>> Aditya Toshniwal
>>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>>>>> "Don't Complain about Heat, Plant a tree"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect *
>>>>>
>>>>>
>>>>>
>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>>> "Don't Complain about Heat, Plant a tree"
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2019-01-24 17:38 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-15 05:19 [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group Aditya Toshniwal <[email protected]>
2019-01-15 12:54 ` Akshay Joshi <[email protected]>
2019-01-18 09:58 ` Aditya Toshniwal <[email protected]>
2019-01-24 14:05 ` Dave Page <[email protected]>
2019-01-24 14:11 ` Aditya Toshniwal <[email protected]>
2019-01-24 14:14 ` Dave Page <[email protected]>
2019-01-24 17:38 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox