public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Neel Patel <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
Date: Thu, 5 Apr 2018 11:27:00 +0530
Message-ID: <CANxoLDfYzVNafMTDvpLzvU4d8gSWoH1agwW9Tqum-SdsvqXZsg@mail.gmail.com> (raw)
In-Reply-To: <CACCA4P0TS39JP8-MQdTq5Nmz=4MprG3gbZZGR5_u5O8ML82P7A@mail.gmail.com>
References: <[email protected]>
<CACCA4P0TS39JP8-MQdTq5Nmz=4MprG3gbZZGR5_u5O8ML82P7A@mail.gmail.com>
Hi Neel
This issue is not due to the above fix, if you can see the error it is
showing in dashboard.js line no 454 "err = JSON.parse(xhr.responseText);"
that code is from long time.
I have just added an extra check of the readyState in case of server is
down in the above commit.
Though it is a bug can you please create a new RM for this.
On Thu, Apr 5, 2018 at 10:52 AM, Neel Patel <[email protected]>
wrote:
> Hi Akshay,
>
> Due to above commit, when user "Drop" any database it gives exception in
> browser console.
> Check attached screenshot.
>
> Thanks,
> Neel Patel
>
>
>
> On Wed, Mar 21, 2018 at 2:08 PM, Dave Page <[email protected]> wrote:
>
>> Fix a number of broken connection detection scenarios.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=637f3b9d1a54df8b9a1bfad9e26f27fdea407683
>> Author: Akshay Joshi <[email protected]>
>>
>> Modified Files
>> --------------
>> web/pgadmin/dashboard/static/js/dashboard.js | 58
>> ++++++++++++--------
>> web/pgadmin/static/js/sqleditor/execute_query.js | 62
>> +++++++++++----------
>> .../js/sqleditor/is_new_transaction_required.js | 9 ++++
>> web/pgadmin/tools/sqleditor/__init__.py | 4 +-
>> web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 ++++---
>> .../tools/sqleditor/tests/test_start_query_tool.py | 2 +-
>> .../tools/sqleditor/utils/start_running_query.py | 63
>> ++++++++++------------
>> .../utils/tests/test_start_running_query.py | 15 +++++-
>> .../user_management/static/js/user_management.js | 13 ++++-
>> .../utils/driver/psycopg2/server_manager.py | 1 +
>> .../javascript/sqleditor/execute_query_spec.js | 48 ++++++++++++-----
>> .../sqleditor/is_new_transaction_required_spec.js | 14 ++---
>> 12 files changed, 195 insertions(+), 114 deletions(-)
>>
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
In-Reply-To: <CANxoLDfYzVNafMTDvpLzvU4d8gSWoH1agwW9Tqum-SdsvqXZsg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox