public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
Date: Tue, 18 Dec 2018 15:00:14 +0530
Message-ID: <CANxoLDfg0xmVoQQ8JU4OAaBmWOxuCWz0Z2eY-ZWPWHDBn2uJ7w@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxno88VLcWxc5ybfDxg=yZNpUFdNCXmKgF4hk_sN50HUQ@mail.gmail.com>
References: <CANxoLDdQr19YWNRgYU+ARs4BgnJGwNBu_51+g0AXWbCC6ZpNNA@mail.gmail.com>
<CA+OCxoxno88VLcWxc5ybfDxg=yZNpUFdNCXmKgF4hk_sN50HUQ@mail.gmail.com>
On Tue, Dec 18, 2018 at 2:49 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix RM #3780 pgAdmin4 lacks ability to specify
>> NULL values in CSV export.
>>
>> Please review it.
>>
>
> A few points;
>
> - You've included code from backports.csv, but per the licence you need to
> include a description of the changes made.
>
Sure. In that case I'll copy the complete file and will do my changes
which is of two lines only. With my patch I have remove all the unwanted
code from backport.csv.
>
> - Shouldn't backports.csv be removed from requirements.txt, or is it used
> elsewhere?
>
Yes. Will do that.
>
> - If the previous point is true, then I'm fairly sure there is code in one
> or more of the many package build scripts that adds an __init__.py file to
> backports.csv in the venv that's created.
>
I'll remove that code as well.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (20+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
In-Reply-To: <CANxoLDfg0xmVoQQ8JU4OAaBmWOxuCWz0Z2eY-ZWPWHDBn2uJ7w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox