public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop
Date: Mon, 13 Apr 2020 14:28:46 +0530
Message-ID: <CANxoLDfh3_YVeB=k0ENT1b-_stGgs56NuY=ZpOEiewuZhrmUmg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZSE2NN73s2nbnoxsNdZAw-nG7TBEvG3bPGx45TDUica9A@mail.gmail.com>
References: <CAKKotZSE2NN73s2nbnoxsNdZAw-nG7TBEvG3bPGx45TDUica9A@mail.gmail.com>

Hi Murtuza

The issue has been fixed with your patch, but there is an existing issue
discover with the fix.
After disconnecting the server and click on Download CSV button
confirmation dialog comes and user needs to click twice.
Following error observed in the browser:

sqleditor.js?ver=42000:1 Uncaught TypeError: Cannot read property 'apply'
of undefined
    at Object.<anonymous> (sqleditor.js?ver=42000:1)
    at Object.callback (vendor.others.js?ver=42000:2)
    at Tt (vendor.others.js?ver=42000:2)
    at Object.Ct (vendor.others.js?ver=42000:2)
    at HTMLDivElement.<anonymous> (vendor.others.js?ver=42000:2)

If possible can you please fix the above and resend the combined patch.

On Fri, Apr 10, 2020 at 7:02 PM Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> Upon downloading the csv file, we used the prompt for re-connecting to the
> database server when there is a database server connection issue. Currently
> the user tries to download CSV and there is a connection issue then it is
> showing a python exception error.
>
> Steps:
> 1) Open query tool
> 2) Execute -> SELECT 1,2,3
> 3) Disconnect from server from browser tree
> 4) Click on Download CSV button
>
> Current: Python exception error
> Expected: It should display dialog to reconnect the server.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop
  In-Reply-To: <CANxoLDfh3_YVeB=k0ENT1b-_stGgs56NuY=ZpOEiewuZhrmUmg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox