public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5227] Cannot add user
Date: Fri, 10 Apr 2020 17:37:39 +0530
Message-ID: <CANxoLDfiAn6_hr3nj9ghocPuPFe_Uz4zKHOwdH+kab0ZCexvzQ@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_kPc2xPMwb_6hrg1RtN-Kv1MxUm=z3tEyFTGQbaM4wk0A@mail.gmail.com>
References: <CAM9w-_=LGp94RH-2Dt4_UtJahCqn_KCNgJLPSak5X3-BPA6phQ@mail.gmail.com>
	<CANxoLDeEWU4_UituX=N_mrmmSHeGuDNOi1r-3jYGfOD3Ti8RFQ@mail.gmail.com>
	<CAM9w-_kPc2xPMwb_6hrg1RtN-Kv1MxUm=z3tEyFTGQbaM4wk0A@mail.gmail.com>

Thanks, patch applied.

On Fri, Apr 10, 2020 at 4:11 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the updated rebased patch.
>
> On Fri, Apr 10, 2020 at 3:13 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Aditya
>>
>> Can you please rebase and send the patch again.
>>
>> On Fri, Apr 10, 2020 at 10:33 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix following user management related issues:
>>> 1) Unable to add a user when there are many users. The dialog went
>>> blank. Fixed.
>>> 2) Error message did not have a close button. Fixed.
>>> 3) When clicked on the add button, then cursor will focus on the email
>>> box of the new row for convenience.
>>> 4) When the dialog opens, the cursor will focus on the search text box.
>>> 5) By default, "User" role will be selected when adding a new user. Also
>>> removed an empty option in the roles dropdown.
>>> 6) When the search filter is applied and we try to add an already
>>> existing user, the validation is done only on the filtered data and not on
>>> all the users data. This is fixed.
>>>
>>> Please review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM5227] Cannot add user
  In-Reply-To: <CANxoLDfiAn6_hr3nj9ghocPuPFe_Uz4zKHOwdH+kab0ZCexvzQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox