public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][RM3866] No way to add row to a table in v4.0
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][RM3866] No way to add row to a table in v4.0
@ 2019-01-11 15:45 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Toshniwal @ 2019-01-11 15:45 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is the patch to fix the issue where last row of data grid is not
visible.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachments:
[application/octet-stream] RM3866.patch (1.5K, 3-RM3866.patch)
download | inline diff:
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index 1a263784..5aa65333 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -62,6 +62,7 @@ $gray-900: $color-fg-theme;
$body-color: $color-fg-theme;
$font-size-base: 0.875rem;
$line-height-base: 1.5; // no change
+$text-height-calc: $line-height-base*$font-size-base/1rem;
$grid-gutter-width: 15px;
$border-radius: 0.25rem; //no change
@@ -169,6 +170,8 @@ $datagrid-bg: $color-gray-light;
$sql-title-padding: 3px;
$sql-title-bg: $color-gray-darker;
$sql-title-fg: $white;
+// Toolbar + editor title heights + title bottom border
+$sql-editor-panel-top: $title-height + $text-height-calc*16px + $sql-title-padding*2 + $panel-border-width;
$sql-gutters-bg: $color-gray-light;
$sql-history-detail-bg: $color-gray-lighter;
$sql-history-success-bg: $color-primary-light;
diff --git a/web/pgadmin/tools/sqleditor/static/scss/_sqleditor.scss b/web/pgadmin/tools/sqleditor/static/scss/_sqleditor.scss
index 5d425bb8..a1cac04d 100644
--- a/web/pgadmin/tools/sqleditor/static/scss/_sqleditor.scss
+++ b/web/pgadmin/tools/sqleditor/static/scss/_sqleditor.scss
@@ -18,6 +18,15 @@
z-index: 0;
}
+#editor-panel {
+ z-index: 0;
+ position: absolute;
+ top: $sql-editor-panel-top;
+ bottom: 0;
+ left: 0;
+ right: 0;
+}
+
#editor-panel .CodeMirror-activeline-background {
background: $color-primary-light;
}
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][RM3866] No way to add row to a table in v4.0
@ 2019-01-11 17:55 Akshay Joshi <[email protected]>
parent: Aditya Toshniwal <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2019-01-11 17:55 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers
Thanks patch applied.
On Fri, Jan 11, 2019 at 9:15 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the patch to fix the issue where last row of data grid is not
> visible.
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-01-11 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 15:45 [pgAdmin4][RM3866] No way to add row to a table in v4.0 Aditya Toshniwal <[email protected]>
2019-01-11 17:55 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox