public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][RM3538] Reset button does not get enabled till all the mandatory fields provided with value in any dialogue.
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM3538] Reset button does not get enabled till all the mandatory fields provided with value in any dialogue.
@ 2019-11-15 05:29 Aditya Toshniwal <[email protected]>
  2019-11-15 06:21 ` Re: [pgAdmin][RM3538] Reset button does not get enabled till all the mandatory fields provided with value in any dialogue. Akshay Joshi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2019-11-15 05:29 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached is the patch to enable reset button of dialog if any field is
changed. Currently, it is enabled only if all the mandatory fields are
provided.

-- 
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM3538.patch (650B, 3-RM3538.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/static/js/node.js b/web/pgadmin/browser/static/js/node.js
index 0f95b1b2d..90e4fb611 100644
--- a/web/pgadmin/browser/static/js/node.js
+++ b/web/pgadmin/browser/static/js/node.js
@@ -346,7 +346,12 @@ define('pgadmin.browser.node', [
                 this.empty().css('visibility', 'hidden');
               }.bind(that.statusBar));
             }
-            callback(true);
+
+            var sessHasChanged = false;
+            if(this.sessChanged && this.sessChanged()){
+              sessHasChanged = true;
+            }
+            callback(true, sessHasChanged);
 
             return true;
           };


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM3538] Reset button does not get enabled till all the mandatory fields provided with value in any dialogue.
  2019-11-15 05:29 [pgAdmin][RM3538] Reset button does not get enabled till all the mandatory fields provided with value in any dialogue. Aditya Toshniwal <[email protected]>
@ 2019-11-15 06:21 ` Akshay Joshi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2019-11-15 06:21 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Thanks, patch applied.

On Fri, Nov 15, 2019 at 11:00 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the patch to enable reset button of dialog if any field is
> changed. Currently, it is enabled only if all the mandatory fields are
> provided.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2019-11-15 06:21 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 05:29 [pgAdmin][RM3538] Reset button does not get enabled till all the mandatory fields provided with value in any dialogue. Aditya Toshniwal <[email protected]>
2019-11-15 06:21 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox