public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table
Date: Wed, 1 Apr 2020 18:21:38 +0530
Message-ID: <CANxoLDfs0X_b5DEbAzG0pTi6=D64E7TJ_jqZZH0so6Mi1Mu02Q@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_nVp54STOdpQi3fTJQ5waOwnwHZfotxuUXaasR1sa0HnA@mail.gmail.com>
References: <CAM9w-_k7QzXDVsbVc5DQ-5sgOqJbnK3uBnAAZdWDG=Eo=n3q=w@mail.gmail.com>
<CANxoLDduZU9KZga=DMnF=4R2pUzabgS6r4nMMrF6mFRNnKKcEw@mail.gmail.com>
<CAM9w-_nu1PxycHL9+h3S1dAzrtaxe6MPnoqL+vtE3F_AkeVy0Q@mail.gmail.com>
<CANxoLDfPOTMfNN9S4s7Cqnd-Z8LUWo8KxVe=s+ur2Sm9xjbYGg@mail.gmail.com>
<CANxoLDfxpwh=ciNvPSL1QyjNoaSnToPWXwTkC3O9Qag0CbPD0g@mail.gmail.com>
<CAM9w-_nVp54STOdpQi3fTJQ5waOwnwHZfotxuUXaasR1sa0HnA@mail.gmail.com>
Thanks, patch applied.
On Wed, Apr 1, 2020 at 6:05 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the updated patch. The issue was on PG9.6, fixed that.
> Docs updated.
>
> Please review.
>
> On Wed, Apr 1, 2020 at 5:37 PM Akshay Joshi <[email protected]>
> wrote:
>
>> Documentation and Screenshot need to be updated.
>>
>> On Wed, Apr 1, 2020 at 5:10 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Aditya
>>>
>>> Tested on 9.6, test cases are fixed but wrong SQL generated for tables:
>>> CREATE TABLE public.test
>>> (
>>> col1 bigint
>>> )
>>> WITH (
>>> OIDS = FALSE,,
>>> parallel_workers = 56 autovacuum_enabled = TRUE,
>>>
>>> Also parameter parallel_workers is not showing until we enabled the
>>> autovacuum parameters.
>>>
>>> Please fix and resend the patch.
>>>
>>> On Wed, Apr 1, 2020 at 3:35 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Akshay,
>>>>
>>>> On Wed, Apr 1, 2020 at 2:51 PM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Aditya
>>>>>
>>>>> API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above.
>>>>> Please fix and resend the patch.
>>>>>
>>>> The SQL is corrected for 9.6 versions. Others seems to be working fine.
>>>> Attached is the updated patch.
>>>> Please review.
>>>>
>>>>>
>>>>> On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is a patch to add support for parameters toast_tuple_target
>>>>>> (PG v11+) and parallel_workers(PG 9.6+) of table. Refer -
>>>>>> https://www.postgresql.org/docs/11/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS
>>>>>> .
>>>>>>
>>>>>> Both the parameters are added in the advanced tab of table dialog.
>>>>>>
>>>>>> The patch also fixes a related issue - RM5180,
>>>>>> where autovacuum_enabled parameter is added automatically in the RE-SQL
>>>>>> when table has been created with WITH parameter.
>>>>>>
>>>>>> Please review.
>>>>>>
>>>>>> --
>>>>>> Thanks and Regards,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect*
>>>>> *EnterpriseDB Software India Private Limited*
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (7+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table
In-Reply-To: <CANxoLDfs0X_b5DEbAzG0pTi6=D64E7TJ_jqZZH0so6Mi1Mu02Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox