public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze
Date: Wed, 20 Jan 2021 18:10:17 +0530
Message-ID: <CANxoLDfyEpG+DDrpzvJ_Xfy95A5HsSqo3YqQQ5PO-KBX_r=Fsg@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_kWgUUgepx3d96uJMWkpCQHvgChQtV+zzj0s41x3kWsfQ@mail.gmail.com>
References: <CAM9w-_=KPNn63qWUtgfRrOpCDjxq3LFi32_eXTAXjn_AkHX8wQ@mail.gmail.com>
<CANxoLDeR2s8f6Amc22HvBQxuotFxH=DM5nA41d33-e2dSOt__g@mail.gmail.com>
<CAM9w-_==zEUfHD63TpKbBAMUxNxLwOO01LtiNLSrT9M8oL-eDw@mail.gmail.com>
<CANxoLDf7HmHSLePRbnfgU3=pt4KmZnAdsVdiUBhC2pBe7_W9aw@mail.gmail.com>
<CAM9w-_kWgUUgepx3d96uJMWkpCQHvgChQtV+zzj0s41x3kWsfQ@mail.gmail.com>
Thanks, patch applied.
On Wed, Jan 20, 2021 at 4:37 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached patch:
> 1) Fixes the broken explain GUI test case.
> 2) Displays a tooltip "Click for details..." on hover over explain plan
> nodes.
>
> Please review.
>
> On Tue, Jan 12, 2021 at 4:45 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Akshay,
>>>
>>> Attached is the updated patch. Please review.
>>>
>>> On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Hi Aditya
>>>>
>>>> Code looks good to me. Below are the review comments:
>>>>
>>>> - Copy and Paste not working in the popup.
>>>> - Documentation needs to be updated.
>>>>
>>>>
>>>> On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached patch improves the way explain plan details tooltip for a
>>>>> node is shown. With the change, popup with details will be shown upon
>>>>> clicking a node, and it will remain open until explicitly closed.
>>>>>
>>>>> Please review.
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>>>> <http://edbpostgres.com;
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Principal Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> <http://edbpostgres.com;
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze
In-Reply-To: <CANxoLDfyEpG+DDrpzvJ_Xfy95A5HsSqo3YqQQ5PO-KBX_r=Fsg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox