public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM-6122]: There is no informative message when there is no diff found
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM-6122]: There is no informative message when there is no diff found
@ 2021-01-15 06:13 Nikhil Mohite <[email protected]>
2021-01-15 08:34 ` Re: [pgAdmin][RM-6122]: There is no informative message when there is no diff found Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Nikhil Mohite @ 2021-01-15 06:13 UTC (permalink / raw)
To: pgadmin-hackers
Hi Team,
Please find the attached patch for RM-6122
<https://redmine.postgresql.org/issues/6122;: There is no informative
message when there is no diff found.
--
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/;
*Mob.No: +91-7798364578.*
Attachments:
[application/octet-stream] RM_6122.patch (1.3K, 3-RM_6122.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js b/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
index 1808e80f..ee0a10c5 100644
--- a/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
+++ b/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
@@ -307,6 +307,16 @@ export default class SchemaDiffUI {
return false;
}
+ check_empty_diff() {
+ var self = this;
+ this.panel_obj.$container.find('#schema-diff-grid .slick-viewport .pg-panel-message').remove();
+ if(self.dataView.getFilteredItems().length == 0) {
+ let msg = gettext('No difference found');
+ this.panel_obj.$container.find('#schema-diff-grid .slick-viewport'
+ ).prepend('<div class="pg-panel-message">'+ msg +'</div>');
+ }
+ }
+
render_grid(data) {
var self = this;
@@ -315,6 +325,7 @@ export default class SchemaDiffUI {
if (self.grid) {
// Only render the data
self.render_grid_data(data);
+ self.check_empty_diff();
return;
}
// Checkbox Column
@@ -854,6 +865,7 @@ export default class SchemaDiffUI {
if(!_.isUndefined(self.dataView) && !_.isNull(self.dataView)) {
// Refresh the grid
self.dataView.refresh();
+ self.check_empty_diff();
}
}
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][RM-6122]: There is no informative message when there is no diff found
2021-01-15 06:13 [pgAdmin][RM-6122]: There is no informative message when there is no diff found Nikhil Mohite <[email protected]>
@ 2021-01-15 08:34 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2021-01-15 08:34 UTC (permalink / raw)
To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Fri, Jan 15, 2021 at 11:44 AM Nikhil Mohite <
[email protected]> wrote:
> Hi Team,
>
> Please find the attached patch for RM-6122
> <https://redmine.postgresql.org/issues/6122;: There is no informative
> message when there is no diff found.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-01-15 08:34 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 06:13 [pgAdmin][RM-6122]: There is no informative message when there is no diff found Nikhil Mohite <[email protected]>
2021-01-15 08:34 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox