public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin][RM-6157]: UI issue in delete records. 4+ messages / 2 participants [nested] [flat]
* [pgAdmin][RM-6157]: UI issue in delete records. @ 2021-02-04 11:31 Nikhil Mohite <[email protected]> 2021-02-05 08:46 ` Re: [pgAdmin][RM-6157]: UI issue in delete records. Akshay Joshi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Nikhil Mohite @ 2021-02-04 11:31 UTC (permalink / raw) To: pgadmin-hackers Hi Team, Please find the attached patch for RM-6157 <https://redmine.postgresql.org/issues/6157;: UI issue in delete records. 1. Resolved CSS issue in delete records from a data-output table. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* <https://www.enterprisedb.com/; *Mob.No: +91-7798364578.* Attachments: [application/octet-stream] RM_6157.patch (993B, 3-RM_6157.patch) download | inline diff: diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js index 21cb4c88..34985b80 100644 --- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js +++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js @@ -1051,6 +1051,15 @@ define('tools.querytool', [ }; self.handler.slickgrid = grid; + // Add listener on data-grid table scroll. + self.handler.slickgrid.onScroll.subscribe(function() { + if(Object.keys(self.handler.data_store.deleted).length > 0) { + setTimeout(() => { + $(self.handler.gridView.grid.getCanvasNode()).find('div.selected').removeClass('strikeout'); + $(self.handler.gridView.grid.getCanvasNode()).find('div.selected').addClass('strikeout'); + }, 100); + } + }); self.handler.slickgrid.CSVOptions = { quoting: self.preferences.results_grid_quoting, quote_char: self.preferences.results_grid_quote_char, ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM-6157]: UI issue in delete records. 2021-02-04 11:31 [pgAdmin][RM-6157]: UI issue in delete records. Nikhil Mohite <[email protected]> @ 2021-02-05 08:46 ` Akshay Joshi <[email protected]> 2021-02-09 11:11 ` Re: [pgAdmin][RM-6157]: UI issue in delete records. Nikhil Mohite <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Akshay Joshi @ 2021-02-05 08:46 UTC (permalink / raw) To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers Thanks, patch applied. On Thu, Feb 4, 2021 at 5:02 PM Nikhil Mohite <[email protected]> wrote: > Hi Team, > > Please find the attached patch for RM-6157 > <https://redmine.postgresql.org/issues/6157;: UI issue in delete records. > 1. Resolved CSS issue in delete records from a data-output table. > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postgres* <https://www.enterprisedb.com/; > *Mob.No: +91-7798364578.* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres <http://edbpostgres.com>* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM-6157]: UI issue in delete records. 2021-02-04 11:31 [pgAdmin][RM-6157]: UI issue in delete records. Nikhil Mohite <[email protected]> 2021-02-05 08:46 ` Re: [pgAdmin][RM-6157]: UI issue in delete records. Akshay Joshi <[email protected]> @ 2021-02-09 11:11 ` Nikhil Mohite <[email protected]> 2021-02-10 12:12 ` Re: [pgAdmin][RM-6157]: UI issue in delete records. Akshay Joshi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Nikhil Mohite @ 2021-02-09 11:11 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers Hi Akshay/ Team, Please find the updated patch for RM-6157. 1. Resolved issue related to strikeout (Red strike-through line which indicates delete records) is getting removed on scrolling for index(Serial) column of the table. Regards, Nikhil Mohite. On Fri, Feb 5, 2021 at 2:16 PM Akshay Joshi <[email protected]> wrote: > Thanks, patch applied. > > On Thu, Feb 4, 2021 at 5:02 PM Nikhil Mohite < > [email protected]> wrote: > >> Hi Team, >> >> Please find the attached patch for RM-6157 >> <https://redmine.postgresql.org/issues/6157;: UI issue in delete records. >> 1. Resolved CSS issue in delete records from a data-output table. >> >> -- >> *Thanks & Regards,* >> *Nikhil Mohite* >> *Software Engineer.* >> *EDB Postgres* <https://www.enterprisedb.com/; >> *Mob.No: +91-7798364578.* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > Attachments: [application/octet-stream] RM_6157_v2.patch (1.1K, 3-RM_6157_v2.patch) download | inline diff: diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js index 34985b80..459e3f07 100644 --- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js +++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js @@ -1053,6 +1053,18 @@ define('tools.querytool', [ self.handler.slickgrid = grid; // Add listener on data-grid table scroll. self.handler.slickgrid.onScroll.subscribe(function() { + // Mark selected rows cells as selected. + setTimeout(() => { + // Can't use setSelectedRows as we are using cellSelectionModel. + var cellSelectionModel = self.handler.gridView.grid.getSelectionModel(); + var ranges = cellSelectionModel.getSelectedRanges(); + + if (ranges.length > 1) { + // Set selected rows cell as selected. + cellSelectionModel.setSelectedRanges(ranges); + } + }, 100); + if(Object.keys(self.handler.data_store.deleted).length > 0) { setTimeout(() => { $(self.handler.gridView.grid.getCanvasNode()).find('div.selected').removeClass('strikeout'); ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM-6157]: UI issue in delete records. 2021-02-04 11:31 [pgAdmin][RM-6157]: UI issue in delete records. Nikhil Mohite <[email protected]> 2021-02-05 08:46 ` Re: [pgAdmin][RM-6157]: UI issue in delete records. Akshay Joshi <[email protected]> 2021-02-09 11:11 ` Re: [pgAdmin][RM-6157]: UI issue in delete records. Nikhil Mohite <[email protected]> @ 2021-02-10 12:12 ` Akshay Joshi <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Akshay Joshi @ 2021-02-10 12:12 UTC (permalink / raw) To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers Thanks, patch applied. On Tue, Feb 9, 2021 at 4:41 PM Nikhil Mohite <[email protected]> wrote: > Hi Akshay/ Team, > > Please find the updated patch for RM-6157. > 1. Resolved issue related to strikeout (Red strike-through line which > indicates delete records) is getting removed on scrolling for > index(Serial) column of the table. > > > Regards, > Nikhil Mohite. > > > On Fri, Feb 5, 2021 at 2:16 PM Akshay Joshi <[email protected]> > wrote: > >> Thanks, patch applied. >> >> On Thu, Feb 4, 2021 at 5:02 PM Nikhil Mohite < >> [email protected]> wrote: >> >>> Hi Team, >>> >>> Please find the attached patch for RM-6157 >>> <https://redmine.postgresql.org/issues/6157;: UI issue in delete >>> records. >>> 1. Resolved CSS issue in delete records from a data-output table. >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Software Engineer.* >>> *EDB Postgres* <https://www.enterprisedb.com/; >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres <http://edbpostgres.com>* >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres <http://edbpostgres.com>* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2021-02-10 12:12 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-02-04 11:31 [pgAdmin][RM-6157]: UI issue in delete records. Nikhil Mohite <[email protected]> 2021-02-05 08:46 ` Akshay Joshi <[email protected]> 2021-02-09 11:11 ` Nikhil Mohite <[email protected]> 2021-02-10 12:12 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox