public inbox for [email protected]  
help / color / mirror / Atom feed
[pgAdmin][RM-5119]: Hanging symlinks in a directory cause select file dialog to break.
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM-5119]: Hanging symlinks in a directory cause select file dialog to break.
@ 2021-03-03 08:37  Nikhil Mohite <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Nikhil Mohite @ 2021-03-03 08:37 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Please find the attached patch for RM-5119
<https://redmine.postgresql.org/issues/5119;: Hanging symlinks in a
directory cause select file dialog to break.
The issue was due to a broken symlink exception was occurring while reading
the file-related data.


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/;
*Mob.No: +91-7798364578.*


Attachments:

  [application/octet-stream] RM-5119.patch (1.1K, 3-RM-5119.patch)
  download | inline diff:
diff --git a/web/pgadmin/misc/file_manager/__init__.py b/web/pgadmin/misc/file_manager/__init__.py
index 9801b7c3..6a98d4bc 100644
--- a/web/pgadmin/misc/file_manager/__init__.py
+++ b/web/pgadmin/misc/file_manager/__init__.py
@@ -603,11 +603,13 @@ class Filemanager(object):
             # continue if file/folder is hidden (based on user preference)
             if not show_hidden_files and is_folder_hidden(system_path):
                 continue
-
-            user_path = os.path.join(os.path.join(user_dir, f))
-            created = time.ctime(os.path.getctime(system_path))
-            modified = time.ctime(os.path.getmtime(system_path))
-            file_extension = str(splitext(system_path))
+            try:
+                user_path = os.path.join(os.path.join(user_dir, f))
+                created = time.ctime(os.path.getctime(system_path))
+                modified = time.ctime(os.path.getmtime(system_path))
+                file_extension = str(splitext(system_path))
+            except Exception as e:
+                continue
 
             # set protected to 1 if no write or read permission
             protected = 0


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM-5119]: Hanging symlinks in a directory cause select file dialog to break.
@ 2021-03-04 08:24  Akshay Joshi <[email protected]>
  parent: Nikhil Mohite <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2021-03-04 08:24 UTC (permalink / raw)
  To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers

Thanks, patch applied.

On Wed, Mar 3, 2021 at 2:07 PM Nikhil Mohite <[email protected]>
wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-5119
> <https://redmine.postgresql.org/issues/5119;: Hanging symlinks in a
> directory cause select file dialog to break.
> The issue was due to a broken symlink exception was occurring while
> reading the file-related data.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2021-03-04 08:24 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 08:37 [pgAdmin][RM-5119]: Hanging symlinks in a directory cause select file dialog to break. Nikhil Mohite <[email protected]>
2021-03-04 08:24 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox