public inbox for [email protected]help / color / mirror / Atom feed
Regarding feature #5908 4+ messages / 4 participants [nested] [flat]
* Regarding feature #5908 @ 2023-09-29 05:42 Nikhil Mohite <[email protected]> 2023-09-29 07:02 ` Re: Regarding feature #5908 Akshay Joshi <[email protected]> 2023-10-02 08:23 ` Re: Regarding feature #5908 Dave Page <[email protected]> 0 siblings, 2 replies; 4+ messages in thread From: Nikhil Mohite @ 2023-09-29 05:42 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, I am currently working on #5908 <https://github.com/pgadmin-org/pgadmin4/issues/5908; Ability to Edit the View/Edit Data Query as if it were a query tool pane. To achieve this there are 2 different approaches: 1. Allow users to promote existing View/Edit data window to Query Tool. 1. Give a button on the View/Edit data toolbar to convert the View/Edit data to the Query tool, after this users will able to edit the queries 2. [image: image.png] 3. In View/Edit data we can move the Query section with the Data output panel so the user can use the maximum space to see the actual result. (This is UI enhancement) 4. Click on "Promote to Query Tool" will confirm from the user whether the user wants to promote View/Edit Data to Query Tool or not, after confirmation from the user it will promote View/Edit data to query tool. 5. Once promoted to Query Tool it will not be able to use the *Filters* and *Limit* options that are available in View/Edit Data. 2. Allow the users to open a new Query Tool from View/Edit Data with Query. 1. Give an option on the View/Edit data connection bar to open a new Query Tool with the current query (Query present in View/Edit data query window). Currently, we have an open new query tool button already present, we will just add a new option to that button that the user can select from the dropdown. 2. [image: Screenshot 2023-09-29 at 10.53.29 AM.png] 3. With this, the View/Edit Data will not allow the edit query and simply open a new Query Tool with a pre-written query. 4. We can add the UI enhancements with this option as well to move the Query section to Data Output. (3rd point from 1st approach) Please let me know your suggestions/thoughts. and which approach we should go with. -- *Thanks & Regards,* *Nikhil Mohite* *Senior Software Engineer.* *EDB Postgres* <https://www.enterprisedb.com/; *Mob.No: +91-7798364578.* Attachments: [image/png] image.png (209.1K, 3-image.png) download | view image [image/png] Screenshot 2023-09-29 at 10.53.29 AM.png (199.9K, 4-Screenshot%202023-09-29%20at%2010.53.29%20AM.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Regarding feature #5908 2023-09-29 05:42 Regarding feature #5908 Nikhil Mohite <[email protected]> @ 2023-09-29 07:02 ` Akshay Joshi <[email protected]> 2023-09-29 12:37 ` Re: Regarding feature #5908 Aditya Toshniwal <[email protected]> 1 sibling, 1 reply; 4+ messages in thread From: Akshay Joshi @ 2023-09-29 07:02 UTC (permalink / raw) To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers Hi Nikhil On Fri, Sep 29, 2023 at 11:13 AM Nikhil Mohite < [email protected]> wrote: > Hi Hackers, > > I am currently working on #5908 > <https://github.com/pgadmin-org/pgadmin4/issues/5908; Ability to Edit the > View/Edit Data Query as if it were a query tool pane. > > To achieve this there are 2 different approaches: > 1. Allow users to promote existing View/Edit data window to Query Tool. > > 1. Give a button on the View/Edit data toolbar to convert the > View/Edit data to the Query tool, after this users will able to edit the > queries > 2. [image: image.png] > 3. In View/Edit data we can move the Query section with the Data > output panel so the user can use the maximum space to see the actual > result. (This is UI enhancement) > 4. Click on "Promote to Query Tool" will confirm from the user whether > the user wants to promote View/Edit Data to Query Tool or not, after > confirmation from the user it will promote View/Edit data to query tool. > 5. Once promoted to Query Tool it will not be able to use the *Filters* > and *Limit* options that are available in View/Edit Data. > > 2. Allow the users to open a new Query Tool from View/Edit Data with Query. > > 1. Give an option on the View/Edit data connection bar to open a new > Query Tool with the current query (Query present in View/Edit data query > window). Currently, we have an open new query tool button already present, > we will just add a new option to that button that the user can select from > the dropdown. > 2. [image: Screenshot 2023-09-29 at 10.53.29 AM.png] > 3. With this, the View/Edit Data will not allow the edit query and > simply open a new Query Tool with a pre-written query. > 4. We can add the UI enhancements with this option as well to move the > Query section to Data Output. (3rd point from 1st approach) > > > Please let me know your suggestions/thoughts. and which approach we should > go with. > I am inclined toward 2nd approach with UI enhancements to move the Query section to Data Output. > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Senior Software Engineer.* > *EDB Postgres* <https://www.enterprisedb.com/; > *Mob.No: +91-7798364578.* > Attachments: [image/png] image.png (209.1K, 3-image.png) download | view image [image/png] Screenshot 2023-09-29 at 10.53.29 AM.png (199.9K, 4-Screenshot%202023-09-29%20at%2010.53.29%20AM.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Regarding feature #5908 2023-09-29 05:42 Regarding feature #5908 Nikhil Mohite <[email protected]> 2023-09-29 07:02 ` Re: Regarding feature #5908 Akshay Joshi <[email protected]> @ 2023-09-29 12:37 ` Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Aditya Toshniwal @ 2023-09-29 12:37 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: Nikhil Mohite <[email protected]>; pgadmin-hackers Hi Nikhil, I am fine with both approaches. If we're going with the 2nd one then I don't think we'll need an open query tool button. In fact, we can re-shuffle the UI to make toolbar more compact and show only relevant to view/edit data. On Fri, Sep 29, 2023 at 12:32 PM Akshay Joshi <[email protected]> wrote: > Hi Nikhil > > > On Fri, Sep 29, 2023 at 11:13 AM Nikhil Mohite < > [email protected]> wrote: > >> Hi Hackers, >> >> I am currently working on #5908 >> <https://github.com/pgadmin-org/pgadmin4/issues/5908; Ability to Edit >> the View/Edit Data Query as if it were a query tool pane. >> >> To achieve this there are 2 different approaches: >> 1. Allow users to promote existing View/Edit data window to Query Tool. >> >> 1. Give a button on the View/Edit data toolbar to convert the >> View/Edit data to the Query tool, after this users will able to edit the >> queries >> 2. [image: image.png] >> 3. In View/Edit data we can move the Query section with the Data >> output panel so the user can use the maximum space to see the actual >> result. (This is UI enhancement) >> 4. Click on "Promote to Query Tool" will confirm from the user >> whether the user wants to promote View/Edit Data to Query Tool or not, >> after confirmation from the user it will promote View/Edit data to query >> tool. >> 5. Once promoted to Query Tool it will not be able to use the >> *Filters* and *Limit* options that are available in View/Edit Data. >> >> 2. Allow the users to open a new Query Tool from View/Edit Data with >> Query. >> >> 1. Give an option on the View/Edit data connection bar to open a new >> Query Tool with the current query (Query present in View/Edit data query >> window). Currently, we have an open new query tool button already present, >> we will just add a new option to that button that the user can select from >> the dropdown. >> 2. [image: Screenshot 2023-09-29 at 10.53.29 AM.png] >> 3. With this, the View/Edit Data will not allow the edit query and >> simply open a new Query Tool with a pre-written query. >> 4. We can add the UI enhancements with this option as well to move >> the Query section to Data Output. (3rd point from 1st approach) >> >> >> Please let me know your suggestions/thoughts. and which approach we >> should go with. >> > > > I am inclined toward 2nd approach with UI enhancements to move the > Query section to Data Output. > >> >> -- >> *Thanks & Regards,* >> *Nikhil Mohite* >> *Senior Software Engineer.* >> *EDB Postgres* <https://www.enterprisedb.com/; >> *Mob.No: +91-7798364578.* >> > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] image.png (209.1K, 3-image.png) download | view image [image/png] Screenshot 2023-09-29 at 10.53.29 AM.png (199.9K, 4-Screenshot%202023-09-29%20at%2010.53.29%20AM.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Regarding feature #5908 2023-09-29 05:42 Regarding feature #5908 Nikhil Mohite <[email protected]> @ 2023-10-02 08:23 ` Dave Page <[email protected]> 1 sibling, 0 replies; 4+ messages in thread From: Dave Page @ 2023-10-02 08:23 UTC (permalink / raw) To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers Hi Nikhil, On Fri, 29 Sept 2023 at 06:44, Nikhil Mohite <[email protected]> wrote: > Hi Hackers, > > I am currently working on #5908 > <https://github.com/pgadmin-org/pgadmin4/issues/5908; Ability to Edit the > View/Edit Data Query as if it were a query tool pane. > > To achieve this there are 2 different approaches: > 1. Allow users to promote existing View/Edit data window to Query Tool. > > 1. Give a button on the View/Edit data toolbar to convert the > View/Edit data to the Query tool, after this users will able to edit the > queries > 2. [image: image.png] > 3. In View/Edit data we can move the Query section with the Data > output panel so the user can use the maximum space to see the actual > result. (This is UI enhancement) > 4. Click on "Promote to Query Tool" will confirm from the user whether > the user wants to promote View/Edit Data to Query Tool or not, after > confirmation from the user it will promote View/Edit data to query tool. > 5. Once promoted to Query Tool it will not be able to use the *Filters* > and *Limit* options that are available in View/Edit Data. > > 2. Allow the users to open a new Query Tool from View/Edit Data with Query. > > 1. Give an option on the View/Edit data connection bar to open a new > Query Tool with the current query (Query present in View/Edit data query > window). Currently, we have an open new query tool button already present, > we will just add a new option to that button that the user can select from > the dropdown. > 2. [image: Screenshot 2023-09-29 at 10.53.29 AM.png] > 3. With this, the View/Edit Data will not allow the edit query and > simply open a new Query Tool with a pre-written query. > 4. We can add the UI enhancements with this option as well to move the > Query section to Data Output. (3rd point from 1st approach) > > > Please let me know your suggestions/thoughts. and which approach we should > go with. > The idea that was previously discussed was allowing the user to edit the query, and then upon the first keypress, popping up a warning that says something like: ---- Manually editing the query will cause this View/Edit Data tab to be converted to a Query Tool tab. You will be able to edit the query text freely, but no longer be able to use the toolbar buttons for sorting and filtering data. Do you wish to continue? ---- If the user opts to continue, then promotion will happen. This is how I would like to see this done (with a "Do not show me this again" option on the dialogue, and a corresponding Preferences option to turn the warning back on again). Thanks. -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com Attachments: [image/png] image.png (209.1K, 3-image.png) download | view image [image/png] Screenshot 2023-09-29 at 10.53.29 AM.png (199.9K, 4-Screenshot%202023-09-29%20at%2010.53.29%20AM.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-10-02 08:23 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-09-29 05:42 Regarding feature #5908 Nikhil Mohite <[email protected]> 2023-09-29 07:02 ` Akshay Joshi <[email protected]> 2023-09-29 12:37 ` Aditya Toshniwal <[email protected]> 2023-10-02 08:23 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox