public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nikhil Mohite <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-5404]: Show the login roles that are members of a group role be shown when examining a group role.
Date: Fri, 19 Mar 2021 15:00:33 +0530
Message-ID: <CAOBg0APMFoHi8bwn3g7JKJ3Kww27A3ATbH_oK+nZVMAMiHAcQw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDeAH1yidK0_+3F=PjLeP0ZKwvdPOfyvXmpBck++o-R42w@mail.gmail.com>
References: <CAOBg0AM_a20FJzv_1+Kr2QtPC-4eaRj9S2ZrbYTkvGKtuQDkAQ@mail.gmail.com>
<CANxoLDeAH1yidK0_+3F=PjLeP0ZKwvdPOfyvXmpBck++o-R42w@mail.gmail.com>
Hi Akshay/ Team,
Please find the updated patch.
Details:
1. Hide the close tag icon on the role property tab (for 'Member of' and
'Member' field). - resolved
Regards,
Nikhil Mohite
On Fri, Mar 12, 2021 at 1:34 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, patch applied.
>
> On Wed, Mar 10, 2021 at 5:31 PM Nikhil Mohite <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for RM-5404
>> <https://redmine.postgresql.org/issues/5404;: Show the login roles that
>> are members of a group role be shown when examining a group role.
>> Updated the existing "Role" label to "Member of" and added a new option
>> "Members" to show all the roles that are members of the current Role/Group.
>> Users can add or remove the roles from the list similar to the "Members of"
>> option.
>>
>> Also added 2 UI fixes:
>> 1. "Member of" (Roles in earlier implementation) and "Members" fields
>> (Membership section) should be read-only in the properties panel.
>> 2. If the select2 controller is set to read-only its background color is
>> not getting set as per the theme color. (earlier it is set to '#eee' for
>> all themes.)
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/;
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachments:
[application/octet-stream] RM-5404_v2.patch (673B, 3-RM-5404_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
index 9bfc2b26..dcb99eb2 100644
--- a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
+++ b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
@@ -245,6 +245,7 @@ define('pgadmin.node.role', [
allowClear: data.disabled ? false : true,
placeholder: data.disabled ? '' : gettext('Select roles'),
width: 'style',
+ disabled: data.readonly ? true : false,
}).on('change', function(e) {
$(e.target).find(':selected').each(function() {
});
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM-5404]: Show the login roles that are members of a group role be shown when examining a group role.
In-Reply-To: <CAOBg0APMFoHi8bwn3g7JKJ3Kww27A3ATbH_oK+nZVMAMiHAcQw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox