public inbox for [email protected]
help / color / mirror / Atom feedFrom: John Obaterspok <[email protected]>
To: Sanket Mehta <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2
Date: Wed, 23 Sep 2015 07:38:59 +0200
Message-ID: <CAOscVdLSYUrYZr9kGffOfj=UmxDm=nuvgySVnhBt5oW4G71K0w@mail.gmail.com> (raw)
In-Reply-To: <CAOscVdKfDJJYM1nQeXQ=6NO5ySyz7E4750gNe+-GbfX2nT_YEQ@mail.gmail.com>
References: <CAOscVdK0zqXa8N179ug0MZ3SqQQDsfXaqPSvsa4As2Mx4xR1KA@mail.gmail.com>
<CAG7mmoyScrFdXCY7apkS67S=j3ciQF7=+YX6QENb_rQ0q8ztuQ@mail.gmail.com>
<CA+yw=mPcHKuLwAwKU6qFa_v1mo=OBU_=g_x71vdDB1oK4_BMcg@mail.gmail.com>
<CA+yw=mNFpBWqPYB+_S-L34MbH-MqudY3KiduK7p+cLs4aLB1Bw@mail.gmail.com>
<CAOscVdKfDJJYM1nQeXQ=6NO5ySyz7E4750gNe+-GbfX2nT_YEQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Sanket,
Did you give the patch a try? I would really like it to for the next
release :)
-- john
2015-09-16 20:27 GMT+02:00 John Obaterspok <[email protected]>:
> Hi Sanket,
>
> Attached patch is rebased now.
>
> Regards,
>
> -- john
>
>
> 2015-09-16 11:20 GMT+02:00 Sanket Mehta <[email protected]>:
>
>> Hi John,
>>
>> Patch is not proper.
>> I got below error when I try to apply the patch:
>>
>> error: patch failed: pgadmin/frm/frmQuery.cpp:2435
>> error: pgadmin/frm/frmQuery.cpp: patch does not apply
>>
>> Please do provide the proper patch.
>>
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta <
>> [email protected]> wrote:
>>
>>> Sure Ashesh,
>>>
>>> I will review the patch.
>>>
>>> Regards,
>>> Sanket Mehta
>>> Sr Software engineer
>>> Enterprisedb
>>>
>>> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi <
>>> [email protected]> wrote:
>>>
>>>> Sanket,
>>>>
>>>> Can you please take a look at it?
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com;
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>
>>>> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok <
>>>> [email protected]> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> I'm updated the patch to add commit/rollback actions in the toolbar
>>>>> with the following:
>>>>> 1) updated icons (based on existing pgadmin icon with arrows drawn by
>>>>> me)
>>>>> 2) add entry to menu as well
>>>>> 3) disable icons when not in a transaction
>>>>> 4) Ctrl+Shift C|R shortcut
>>>>>
>>>>> Hopefully all issues are resolved now!
>>>>>
>>>>> Regards,
>>>>>
>>>>> John
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Sent via pgadmin-hackers mailing list ([email protected])
>>>>> To make changes to your subscription:
>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>
>>>>>
>>>>
>>>
>>
>
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2
In-Reply-To: <CAOscVdLSYUrYZr9kGffOfj=UmxDm=nuvgySVnhBt5oW4G71K0w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox