public inbox for [email protected]
help / color / mirror / Atom feedFrom: Shirley Wang <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Style guide live website - looking for feedback
Date: Thu, 08 Jun 2017 14:41:57 +0000
Message-ID: <CAPG3WN50HsP81rnPS63m3TcmWtFT0fqufXdK4EHBU=TW-9d11A@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozO9NuT33X9L2MBju6prBr7ZdoktdivAR6Z=EYERY52bg@mail.gmail.com>
References: <CAPG3WN6-gARPJ_pDGZzzxv=2wRN-GcFa2+9CmruKLgmw8sM1Lg@mail.gmail.com>
<CA+OCxozO9NuT33X9L2MBju6prBr7ZdoktdivAR6Z=EYERY52bg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
>
>
> Looks good. A couple of thoughts:
>
> - Please use "pgAdmin 4" consistently :-)
>
> Just to clarify - is there always a space between pgAdmin and 4? or is it
pgAdmin4?
> - The neutral message panel has a border that is quite visible, whilst
> the others have much more subtle borders. Seems like something to fix.
>
It is an interesting contrast. I think it should be changed too.
>
> - I think we need some notes on when the different font sizes should be
> used.
>
> Ok. I can start documenting where these fonts are used now, and then we
can think about if that's how we actually want to use them.
> - You've obviously created classes for these styles (e.g. text-14).
> Let's make sure they are all actually defined in the stylesheets for
> the app before we add the style guide :-)
>
> Will do.
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Style guide live website - looking for feedback
In-Reply-To: <CAPG3WN50HsP81rnPS63m3TcmWtFT0fqufXdK4EHBU=TW-9d11A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox