public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Fix function signature generation. Fixes #1683
2+ messages / 1 participants
[nested] [flat]
* pgAdmin 4 commit: Fix function signature generation. Fixes #1683
@ 2016-09-12 14:21 Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-09-12 14:21 UTC (permalink / raw)
To: pgadmin-hackers
Fix function signature generation. Fixes #1683
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2ed6fa4dd88a5941680bb369ebdd4ff80024...
Author: Surinder Kumar <[email protected]>
Modified Files
--------------
.../databases/schemas/functions/__init__.py | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgAdmin 4 commit: Fix function signature generation for reverse enginee
@ 2016-09-14 09:59 Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-09-14 09:59 UTC (permalink / raw)
To: pgadmin-hackers
Fix function signature generation for reverse engineered SQL. Fixes #1674
1) In SQL pane, the signature in comments had arguments with name and type, Now it will show arguments with type only.
2) There is no indent+newline between arguments (there isn't even a space). - Fixed
3) The default value for the last argument is omitted. - Fixed
Last argument is omitted because the value for the last argument we got from table is empty.
Now we form function signature in the get_definition.sql using 'pg_catalog.pg_get_function_arguments' method.
Above changes will reflect in Functions, Procedures & Trigger function Nodes.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2469d113c97b8d2f434af54fa76d0195af2f...
Author: Surinder Kumar <[email protected]>
Modified Files
--------------
.../databases/schemas/functions/__init__.py | 61 +++++++++++++++++-----
.../templates/function/pg/sql/9.1_plus/create.sql | 4 ++
.../function/pg/sql/9.1_plus/get_definition.sql | 3 +-
.../templates/function/pg/sql/9.2_plus/create.sql | 4 ++
.../function/pg/sql/9.2_plus/get_definition.sql | 3 +-
.../templates/function/pg/sql/9.5_plus/create.sql | 6 ++-
.../function/pg/sql/9.5_plus/get_definition.sql | 3 +-
.../function/ppas/sql/9.1_plus/create.sql | 4 ++
.../function/ppas/sql/9.1_plus/get_definition.sql | 3 +-
.../function/ppas/sql/9.2_plus/create.sql | 4 ++
.../function/ppas/sql/9.2_plus/get_definition.sql | 3 +-
.../function/ppas/sql/9.5_plus/create.sql | 4 ++
.../function/ppas/sql/9.5_plus/get_definition.sql | 3 +-
.../procedure/ppas/sql/9.1_plus/create.sql | 7 ++-
.../procedure/ppas/sql/9.1_plus/get_definition.sql | 4 +-
.../procedure/ppas/sql/9.2_plus/create.sql | 7 ++-
.../procedure/ppas/sql/9.2_plus/get_definition.sql | 4 +-
.../procedure/ppas/sql/9.5_plus/create.sql | 4 ++
.../procedure/ppas/sql/9.5_plus/get_definition.sql | 4 +-
.../pg/sql/9.1_plus/get_definition.sql | 3 +-
.../pg/sql/9.2_plus/get_definition.sql | 3 +-
.../pg/sql/9.5_plus/get_definition.sql | 3 +-
.../ppas/sql/9.1_plus/get_definition.sql | 3 +-
.../ppas/sql/9.2_plus/get_definition.sql | 3 +-
.../ppas/sql/9.5_plus/get_definition.sql | 3 +-
25 files changed, 120 insertions(+), 33 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-09-14 09:59 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 14:21 pgAdmin 4 commit: Fix function signature generation. Fixes #1683 Dave Page <[email protected]>
2016-09-14 09:59 pgAdmin 4 commit: Fix function signature generation for reverse enginee Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox