public inbox for [email protected]  
help / color / mirror / Atom feed
pgAdmin4.cpp - sync missing
2+ messages / 2 participants
[nested] [flat]

* pgAdmin4.cpp - sync missing
@ 2016-04-16 11:25  Vladimir Koković <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Vladimir Koković @ 2016-04-16 11:25 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

settings.sync() missing after the line 110

Vladimir Kokovic
Belgrade Serbia, 16.April 2016

-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] pgAdmin4.cpp.diff (366B, 2-pgAdmin4.cpp.diff)
  download | inline diff:
diff --git a/runtime/pgAdmin4.cpp b/runtime/pgAdmin4.cpp
index f21bc19..1bdfadb 100644
--- a/runtime/pgAdmin4.cpp
+++ b/runtime/pgAdmin4.cpp
@@ -108,8 +108,9 @@
         {
             settings.setValue("PythonPath", pythonpath);
             settings.setValue("ApplicationPath", applicationpath);
+            settings.sync();
         }

         exit(1);
     }



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgAdmin4.cpp - sync missing
@ 2016-04-16 23:01  Dave Page <[email protected]>
  parent: Vladimir Koković <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2016-04-16 23:01 UTC (permalink / raw)
  To: Vladimir Koković <[email protected]>; +Cc: pgadmin-hackers

Hi

On Saturday, April 16, 2016, Vladimir Koković <[email protected]>
wrote:

> Hi,
>
> settings.sync() missing after the line 110
>

Thanks - in theory it shouldn't be needed as it'll be called in the
destructor and periodically in the event loop, but it doesn't hurt to save
anyway.

Patch applied.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2016-04-16 23:01 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-04-16 11:25 pgAdmin4.cpp - sync missing Vladimir Koković <[email protected]>
2016-04-16 23:01 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox