pg.ddx.io  pgbackrest/pgbackrest GitHub issues and pull requests  
help / color / mirror / Atom feed
From: dwsteele (@dwsteele) <noreply+dwsteele@github.com>
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
Subject: Re: [pgbackrest/pgbackrest] PR #2887: DirectIO
Date: Tue, 03 Nov 2026 11:20:59 +0000
Message-ID: <gh-pgbackrest-pgbackrest-2887-c6602475432@github.com> (raw)
In-Reply-To: <gh-pgbackrest-pgbackrest-2887@github.com>
References: <gh-pgbackrest-pgbackrest-2887@github.com>

> Calling fadvise POSIX_FADV_DONTNEED after the read purges the cached pages for that file, it doesn't avoid caching them in the first place.

Sure, but if we do this by buffer rather than for the entire file it would work better. I also think a better way to go might be RWF_DONTCACHE with preadv2()/pwritev2().

> If you think this is adequate I could do the changes you commented and avoid using vscode auto-formatter on-save, because code-format doesn't seem to fix the breaks.

Unfortunately uncrustify won't fix everything -- especially comment formatting. In general it is best to avoid reformatting lines that are not part of the patch.

I think DIO, even though slower, would make a good option but this patch needs to be drastically simpler and right now it is hard to evaluate due to the whitespace changes and unneeded complexity. Please follow my comments and let's see what the patch looks like afterwards.

view thread (20+ messages)  latest in thread

Message-ID: <gh-pgbackrest-pgbackrest-2887-c6602475432@github.com>
Permalink:  ../gh-pgbackrest-pgbackrest-2887-c6602475432@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox