pg.ddx.io  pgbackrest/pgbackrest GitHub issues and pull requests  
help / color / mirror / Atom feed
From: dwsteele (@dwsteele) <noreply+dwsteele@github.com>
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
Subject: Re: [pgbackrest/pgbackrest] PR #2887: DirectIO
Date: Fri, 13 Nov 2026 14:46:53 +0000
Message-ID: <gh-pgbackrest-pgbackrest-2887-c6856331169@github.com> (raw)
In-Reply-To: <gh-pgbackrest-pgbackrest-2887@github.com>
References: <gh-pgbackrest-pgbackrest-2887@github.com>

I made a first pass through this and overall it looks good but as you can see I made significant changes. Mostly they were organizational but there are a few large changes:

1) The last block that would need to be truncated if written with direct IO is written with buffered I/O (see 76823bc7b42f for details/reasons). In practice, especially with bundled backups, this should cause minimal buffered I/O.
2) statx has been removed so alignment > 4096 fails back to buffered I/O. These larger alignments should be rare so I don't think this is a very big deal but let me know if you disagree. I'm fine with bringing it back but I wanted to limit the scope of this patch to what is most useful.

Also I committed the I/O write fix separately in 5929c36f2af6ac. This does not express as a bug in the current code (like it did in the PR) because of how it is used but I felt it deserved a separate commit for clarity.

This still needs more review and I will probably commit the _GNU_SOURCE changes separately, but overall I think the patch is in decent shape.

Let me know what you think.

view thread (20+ messages)  latest in thread

Message-ID: <gh-pgbackrest-pgbackrest-2887-c6856331169@github.com>
Permalink:  ../gh-pgbackrest-pgbackrest-2887-c6856331169@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox