From: fmbiete (@fmbiete) <noreply+fmbiete@github.com>
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
Subject: Re: [pgbackrest/pgbackrest] PR #2887: DirectIO
Date: Tue, 17 Nov 2026 14:19:53 +0000
Message-ID: <gh-pgbackrest-pgbackrest-2887-c6950696995@github.com> (raw)
In-Reply-To: <gh-pgbackrest-pgbackrest-2887@github.com>
References: <gh-pgbackrest-pgbackrest-2887@github.com>
I think I'm ok with those changes.
The last bit as buffered IO is a tread-off, simple, less rase cases prone and it should be a few bytes per file at worse, and since it's at the end the read-ahead of the kernel should not load additional pages.
The aligment should work, but I have some doubts about those kubernetes-operators... I hope they don't backup to any overlay filesystem. But if we identify EINVAL in the first write as fallback to buffered and don't error, it should be ok.
Let me know if I can help you with something.