From: pgstef (@pgstef) <noreply+pgstef@github.com>
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
Subject: Re: [pgbackrest/pgbackrest] PR #2887 (approved): Direct I/O for Posix/CIFS storage.
Date: Tue, 17 Nov 2026 14:34:01 +0000
Message-ID: <gh-pgbackrest-pgbackrest-2887-r5940364851@github.com> (raw)
In-Reply-To: <gh-pgbackrest-pgbackrest-2887@github.com>
References: <gh-pgbackrest-pgbackrest-2887@github.com>
For what it's worth, the current state of this PR looks good to me!
The performance trade-offs of `O_DIRECT` (no readahead or writeback caching, synchronous I/O, and forced writeback of dirty pages on Linux) are documented.
And if I read it correctly, the alignment fix in `db0ccfb79` produces the same aligned address regardless of the requested alignment, stays within the `size + align - 1` allocation, and keeps the pointer derived from the original allocation.
So overall, looks good to me! 👍