pg.ddx.io  pgbackrest/pgbackrest GitHub issues and pull requests  
help / color / mirror / Atom feed
[pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
15+ messages / 3 participants
[nested] [flat]

* [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 10:34  "YegorZ (@YegorZ)" <noreply+YegorZ@github.com>
  0 siblings, 0 replies; 15+ messages in thread

From: YegorZ (@YegorZ) @ 2026-11-06 10:34 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

When a file had the same size as the prior file but the prior file was not stored with block incremental, the zero block incremental values of the prior file were copied over the values calculated at manifest build time. The file was stored without block incremental even though it was eligible and no block map was written. With the default age map this happens to a file that had not been modified for four weeks or more when the full backup was taken and later changes without changing size.

Copy prior block incremental values only when the prior file has a block map. Otherwise keep the values calculated at build time when the file will be copied and zero them when it will not.

A file with no prior map that has a new timestamp but no content change is found to be unchanged after the block incremental filter has returned a map. Limit the assertion on the returned map to files with a prior map and zero the block incremental values of the file when it is referenced to the prior backup.

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 12:28  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-06 12:28 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

This is a good change but your implementation introduced a regression. See f8444e5e for the fix.

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 12:28  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-06 12:28 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

@dwsteele requested a review.

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 12:28  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-06 12:28 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

@dwsteele assigned @dwsteele.

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 12:28  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-06 12:28 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

@dwsteele applied label "module [core]".

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 12:28  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-06 12:28 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

@dwsteele applied label "enhancement".

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 12:28  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-06 12:28 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

@dwsteele set milestone to "2.61.0".

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 12:35  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-06 12:35 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

BTW -- this PR was submitted based on an integration branch more than two months old. It was a clean merge but better to use an up-to-date copy of integration.

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 15:35  "hunleyd (@hunleyd)" <noreply+hunleyd@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: hunleyd (@hunleyd) @ 2026-11-06 15:35 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

(on src/info/manifest/manifest.c:554)

Case: prior file has no map, size is equal, timestamp changed, content unchanged. The build step keeps blockIncrSize/blockIncrChecksumSize because copy=true. The backup then returns NoOp and the manifest is never updated. The saved entry is referenced, "bi" is set, "bim" is absent. This contradicts the PR body ("zero them when the file will be referenced... no map will be written").
fix: Zero bi/bic in the NoOp path when bim == 0.

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905 (changes requested): Preserve block incremental info only when prior file has a block map.
@ 2026-11-06 15:35  "hunleyd (@hunleyd)" <noreply+hunleyd@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: hunleyd (@hunleyd) @ 2026-11-06 15:35 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>



^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-09 15:49  "YegorZ (@YegorZ)" <noreply+YegorZ@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: YegorZ (@YegorZ) @ 2026-11-09 15:49 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

(on src/info/manifest/manifest.c:553)

Yes, you are right. I've fixed the bug. Thanks.

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905 (approved): Preserve block incremental info only when prior file has a block map.
@ 2026-11-10 14:19  "hunleyd (@hunleyd)" <noreply+hunleyd@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: hunleyd (@hunleyd) @ 2026-11-10 14:19 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>



^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905 (approved): Preserve block incremental info only when prior file has a block map.
@ 2026-11-18 17:13  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-18 17:13 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>



^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-18 17:26  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-18 17:26 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

@dwsteele closed this.

^ permalink  raw  [nested|flat] 15+ messages in thread

* Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
@ 2026-11-18 17:26  "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
  13 siblings, 0 replies; 15+ messages in thread

From: dwsteele (@dwsteele) @ 2026-11-18 17:26 UTC (permalink / raw)
  To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>

@dwsteele merged this (commit 1eefc207e82a).

^ permalink  raw  [nested|flat] 15+ messages in thread


end of thread, other threads:[~2026-11-18 17:26 UTC | newest]

Thread overview: 15+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-06 10:34 [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map. "YegorZ (@YegorZ)" <noreply+YegorZ@github.com>
2026-11-06 12:28 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-06 12:28 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-06 12:28 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-06 12:28 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-06 12:28 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-06 12:28 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-06 12:35 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-06 15:35 ` "hunleyd (@hunleyd)" <noreply+hunleyd@github.com>
2026-11-06 15:35 ` Re: [pgbackrest/pgbackrest] PR #2905 (changes requested): Preserve block incremental info only when prior file has a block map. "hunleyd (@hunleyd)" <noreply+hunleyd@github.com>
2026-11-09 15:49 ` "YegorZ (@YegorZ)" <noreply+YegorZ@github.com>
2026-11-10 14:19 ` Re: [pgbackrest/pgbackrest] PR #2905 (approved): Preserve block incremental info only when prior file has a block map. "hunleyd (@hunleyd)" <noreply+hunleyd@github.com>
2026-11-18 17:13 ` Re: [pgbackrest/pgbackrest] PR #2905 (approved): Preserve block incremental info only when prior file has a block map. "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-18 17:26 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-18 17:26 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox