pg.ddx.io  pgbackrest/pgbackrest GitHub issues and pull requests  
help / color / mirror / Atom feed
From: hunleyd (@hunleyd) <noreply+hunleyd@github.com>
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
Subject: Re: [pgbackrest/pgbackrest] PR #2905: Preserve block incremental info only when prior file has a block map.
Date: Fri, 06 Nov 2026 15:35:47 +0000
Message-ID: <gh-pgbackrest-pgbackrest-2905-rc4494240781@github.com> (raw)
In-Reply-To: <gh-pgbackrest-pgbackrest-2905@github.com>
References: <gh-pgbackrest-pgbackrest-2905@github.com>

(on src/info/manifest/manifest.c:554)

Case: prior file has no map, size is equal, timestamp changed, content unchanged. The build step keeps blockIncrSize/blockIncrChecksumSize because copy=true. The backup then returns NoOp and the manifest is never updated. The saved entry is referenced, "bi" is set, "bim" is absent. This contradicts the PR body ("zero them when the file will be referenced... no map will be written").
fix: Zero bi/bic in the NoOp path when bim == 0.

view thread (15+ messages)  latest in thread

Message-ID: <gh-pgbackrest-pgbackrest-2905-rc4494240781@github.com>
Permalink:  ../gh-pgbackrest-pgbackrest-2905-rc4494240781@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox