pg.ddx.io  pgbackrest/pgbackrest GitHub issues and pull requests  
help / color / mirror / Atom feed
From: melancholictheory (@melancholictheory) <noreply+melancholictheory@github.com>
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
Subject: Re: [pgbackrest/pgbackrest] PR #2912: Reduce free-list retention during chunked uploads
Date: Mon, 09 Nov 2026 11:15:20 +0000
Message-ID: <gh-pgbackrest-pgbackrest-2912-c6738671573@github.com> (raw)
In-Reply-To: <gh-pgbackrest-pgbackrest-2912@github.com>
References: <gh-pgbackrest-pgbackrest-2912@github.com>

Thanks, David. I agree with reverting for the November patch release. A single bucket keyed to `buffer-size` makes sense if we bring the cache back.

I compared the #2914 revert (`f8b4d4a1d`) with a prototype that caches only allocations of exactly `buffer-size`, with up to eight blocks per process. Both used the same upload code, local MinIO on Linux arm64, `buffer-size=1MiB`, 5 MiB S3 chunks, zstd level 1, and `process-max=16`.

| Workload | Version | Peak summed RssAnon (MiB), per run | Elapsed (s), per run |
| --- | --- | --- | --- |
| Async archive-push, same 231 PostgreSQL 18 WAL segments | Revert | 322.5 / 322.5 / 321.3 | 27.74 / 16.74 / 14.06 |
| | One bucket | 349.2 / 654.8 / 341.2 | 23.45 / 146.69 / 23.19 |
| Full backup, 785 MiB, archive check disabled for this measurement | Revert | 80.9 / 82.0 | 12.06 / 7.72 |
| | One bucket | 83.7 / 84.2 | 7.80 / 7.96 |

I retrieved all 231 segments from both variants in the first pair and verified their SHA-256 hashes against the originals. The slow archive-push run with the one-bucket prototype did not repeat in the third pair, so I would treat it as an unexplained outlier. On backup the one-bucket variant recorded roughly 17–23% fewer minor faults, with elapsed times near the faster revert run.

I'd ship the revert and revisit the single-size cache if a workload shows a repeatable elapsed-time improvement from the reduction in page faults.


view thread (20+ messages)  latest in thread

Message-ID: <gh-pgbackrest-pgbackrest-2912-c6738671573@github.com>
Permalink:  ../gh-pgbackrest-pgbackrest-2912-c6738671573@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox