From: dwsteele (@dwsteele) <noreply+dwsteele@github.com>
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
Subject: Re: [pgbackrest/pgbackrest] PR #2917: Add an info helper to load, cache, and save info files.
Date: Fri, 13 Nov 2026 13:28:29 +0000
Message-ID: <gh-pgbackrest-pgbackrest-2917-c6854329748@github.com> (raw)
In-Reply-To: <gh-pgbackrest-pgbackrest-2917@github.com>
References: <gh-pgbackrest-pgbackrest-2917@github.com>
> If I understand correctly, the order the compiler evaluates arguments in no longer matters: the save call can stay as one statement because the cipher spec now gets the storage itself.
Correct. And I simplified the test a bit. It is good to verify that the helper correctly pulls remote credentials but the test as a limited ability to test the ordering issue. After all, the prior code already worked on multiple compilers and architectures with no issue. Compilers *can* reorder the calls but I think they strive not to in order to prevent this kind of bug.