From: pgstef (@pgstef) <noreply+pgstef@github.com>
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
Subject: Re: [pgbackrest/pgbackrest] PR #2921 (approved): Remove support for PostgreSQL 9.6.
Date: Tue, 17 Nov 2026 09:22:27 +0000
Message-ID: <gh-pgbackrest-pgbackrest-2921-r5935844569@github.com> (raw)
In-Reply-To: <gh-pgbackrest-pgbackrest-2921@github.com>
References: <gh-pgbackrest-pgbackrest-2921@github.com>
The PR looks good to me!
I noticed a minor issue during the review. It's not directly related to this PR, since the same behavior already exists for PostgreSQL 9.5 and older, but I thought it might be worth mentioning.
Restoring an older backup fails after cleaning the target data directory. When restoring a retained PostgreSQL 9.6 backup, `manifestSave()` eventually calls `pgControlVersion()`, which throws an "invalid PostgreSQL version 9.6" error. Unfortunately, this happens after `restoreCleanBuild()` has already modified PGDATA (removing `pg_control` and stray files with `--delta`), leaving an empty temporary manifest behind.
Perhaps we should validate the PostgreSQL version earlier, before making any changes to PGDATA?
Since this is a pre-existing issue, I wouldn't suggest fixing it in this PR, but I thought it was worth pointing out while we're touching PostgreSQL version support.