pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2030: fix(cross-shard): compute LIMIT/OFFSET with integer arithmetic and casts
Date: Fri, 13 Nov 2026 09:22:10 +0000
Message-ID: <gh-pgdogdev-pgdog-2030-c6849078575@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2030@github.com>
References: <gh-pgdogdev-pgdog-2030@github.com>
<!-- metal-bench -->
**Metal bench (arm64) passed.** All 517 measures within bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 19.17 (+0.9% ± 1.2%) | 18,839 (+0.0% ± 0.6%) | 32,052 (-0.0% ± 0.04%) | 30,172 (+1.6% ± 2.2%) | 51,094 (-0.0% ± 0.5%) | |
| lb | | 19.7 (-0.5% ± 2.1%) | 19,328 (-0.7% ± 1.2%) | 32,950 (-0.0% ± 0.03%) | 30,792 (-0.4% ± 3.3%) | 52,224 (+0.1% ± 0.4%) | |
| sharding-w2 | | 31.28 (+0.3% ± 0.5%) | 42,920 (-0.4% ± 0.7%) | 97,422 (-0.0% ± 0.01%) | 38,223 (+1.0% ± 1.7%) | 53,709 (-0.0% ± 0.3%) | 1.55 (-0.0% ± 0.2%) |
| sharding-w8 | 252,103 (+0.4% ± 1.3%) | 28.3 (-0.4% ± 1.2%) | 43,378 (-0.9% ± 0.7%) | 52,940 (-0.0% ± 0.02%) | 34,761 (+0.1% ± 2.7%) | 42,406 (-0.0% ± 0.2%) | 0.174 (+0.3% ± 2.5%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 8,184 (-0.1% ± 1.5%) | 2,713 (+0.1% ± 0.7%) | |
| lb | 8,387 (-1.5% ± 2.9%) | 2,756 (-0.6% ± 1.4%) | |
| sharding-w2 | 16,542 (-1.0% ± 2.3%) | 3,930 (-0.5% ± 0.9%) | |
| sharding-w8 | 17,909 (-2.3% ± 3.7%) | 3,792 (-1.0% ± 2.2%) | |
</details>
Microbench: all 504 measures within bounds.
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 112.2 KB | 112.7 KB | **+0.5 KB** |
| sharding-w2 | 164.7 KB | 165.2 KB | **+0.6 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 19.8 KB | 19.5 KB | -0.3 KB |
| tokio | 18.1 KB | 18.4 KB | +0.4 KB |
| pgdog::backend::pool | 17.5 KB | 17.8 KB | +0.2 KB |
| aws-lc (TLS crypto) | 10.3 KB | 10.6 KB | +0.3 KB |
| rustls (TLS) | 8.4 KB | 8.2 KB | -0.2 KB |
| pgdog::frontend (other) | 7.7 KB | 7.9 KB | +0.2 KB |
| pgdog::backend::server | 7.2 KB | 7.4 KB | +0.2 KB |
| other | 6.7 KB | 6.5 KB | -0.2 KB |
| everything else | 16.5 KB | 16.4 KB | -0.1 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.5 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.1 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | +0.2 KB |
| `pgdog::backend::server::Server::read::{{closure}}` | 2.9 KB | +0.2 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 28.5 KB | 28.8 KB | +0.3 KB |
| pgdog::frontend::client::query_engine | 20.8 KB | 20.7 KB | -0.1 KB |
| tokio | 18.8 KB | 18.7 KB | -0.1 KB |
| pgdog::backend::pool | 18.2 KB | 18.0 KB | -0.2 KB |
| aws-lc (TLS crypto) | 13.0 KB | 13.2 KB | +0.2 KB |
| other | 9.5 KB | 9.9 KB | +0.4 KB |
| pgdog::frontend (other) | 8.6 KB | 8.8 KB | +0.1 KB |
| rustls (TLS) | 8.0 KB | 7.9 KB | -0.1 KB |
| everything else | 39.2 KB | 39.2 KB | +0.0 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.0 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | -0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.3 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | -0.1 KB |
</details>
<details><summary>lb flamegraph vs e0844966</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...).
</details>
<details><summary>microbench flamegraph vs e0844966</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...).
</details>
<details><summary>pooler flamegraph vs e0844966</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...).
</details>
<details><summary>sharding-w2 flamegraph vs e0844966</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...).
</details>
<details><summary>sharding-w8 flamegraph vs e0844966</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-limit-expressions/1ff54f5719c91d1c0c0e61611...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-limit-expressions...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-limit-expressions...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-limit-expressions...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-limit-expressions...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-limit-expressions...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-limit-expressions...)
</details>
Compared 1ff54f57 with e0844966 on m8g.metal-24xl (spot).
view thread (10+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2030-c6849078575@github.com>
Permalink: ../gh-pgdogdev-pgdog-2030-c6849078575@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox