pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2030: fix(cross-shard): compute LIMIT/OFFSET with integer arithmetic and casts
Date: Fri, 13 Nov 2026 09:23:49 +0000
Message-ID: <gh-pgdogdev-pgdog-2030-c6849110180@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2030@github.com>
References: <gh-pgdogdev-pgdog-2030@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) passed.** All 517 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 25.94 (+0.0% ± 0.4%) | 18,785 (+0.0% ± 0.1%) | 34,019 (+0.0% ± 0.05%) | 33,719 (-0.0% ± 0.4%) | 36,530 (+0.1% ± 0.7%) |  |
| lb |  | 26.31 (+0.0% ± 0.4%) | 19,313 (+0.1% ± 0.07%) | 34,987 (+0.0% ± 0.02%) | 33,844 (+0.0% ± 0.4%) | 37,332 (+0.2% ± 0.6%) |  |
| sharding-w2 |  | 41.91 (-0.2% ± 0.5%) | 46,970 (-0.1% ± 1.0%) | 101,416 (-0.0% ± 0.01%) | 38,491 (-0.4% ± 1.7%) | 40,180 (+0.0% ± 0.4%) | 1.529 (+0.1% ± 0.3%) |
| sharding-w8 | 206,635 (-0.3% ± 0.2%) | 32.88 (+0.1% ± 0.1%) | 45,785 (+0.2% ± 0.5%) | 55,764 (+0.0% ± 0.2%) | 31,388 (+0.0% ± 1.1%) | 32,503 (+0.0% ± 0.10%) | 0.1731 (+0.6% ± 0.8%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 3,372 (+0.1% ± 0.6%) | 1,200 (+0.6% ± 1.0%) | 37,385 (-0.1% ± 0.7%) |
| lb | 3,499 (+0.0% ± 0.8%) | 1,224 (+0.5% ± 1.1%) | 38,319 (+0.2% ± 0.9%) |
| sharding-w2 | 5,890 (+1.9% ± 2.0%) | 1,636 (+3.2% ± 1.8%) | 113,331 (-1.0% ± 2.4%) |
| sharding-w8 | 3,191 (+2.6% ± 2.4%) | 994 (+3.9% ± 0.6%) | 174,196 (-0.2% ± 1.1%) |
</details>

Microbench: all 504 measures within bounds.

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 112.4 KB | 112.6 KB | **+0.2 KB** |
| sharding-w2 | 165.1 KB | 166.0 KB | **+0.9 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 21.4 KB | 21.7 KB | +0.2 KB |
| pgdog::backend::pool | 18.8 KB | 18.4 KB | -0.3 KB |
| tokio | 18.4 KB | 18.3 KB | -0.1 KB |
| aws-lc (TLS crypto) | 9.2 KB | 9.4 KB | +0.2 KB |
| pgdog::frontend (other) | 9.3 KB | 9.2 KB | -0.1 KB |
| rustls (TLS) | 7.9 KB | 7.9 KB | -0.1 KB |
| pgdog::backend::server | 6.9 KB | 7.0 KB | +0.1 KB |
| other | 5.8 KB | 6.1 KB | +0.3 KB |
| everything else | 14.7 KB | 14.7 KB | +0.0 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.1 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.3 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.9 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.6 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.3 KB | +0.0 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 28.6 KB | 29.2 KB | +0.6 KB |
| pgdog::frontend::client::query_engine | 23.1 KB | 23.1 KB | +0.0 KB |
| pgdog::backend::pool | 18.8 KB | 18.6 KB | -0.1 KB |
| tokio | 18.3 KB | 18.2 KB | -0.1 KB |
| aws-lc (TLS crypto) | 10.5 KB | 10.8 KB | +0.3 KB |
| pgdog::frontend (other) | 10.7 KB | 10.7 KB | +0.0 KB |
| other | 10.4 KB | 10.2 KB | -0.2 KB |
| pgdog::backend::server | 7.8 KB | 7.8 KB | +0.0 KB |
| everything else | 37.0 KB | 37.5 KB | +0.5 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 8.2 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.7 KB | +0.0 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.2 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.9 KB | -0.1 KB |

</details>

<details><summary>lb flamegraph vs e0844966</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...).
</details>
<details><summary>microbench flamegraph vs e0844966</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...).
</details>
<details><summary>pooler flamegraph vs e0844966</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...).
</details>
<details><summary>sharding-w2 flamegraph vs e0844966</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...).
</details>
<details><summary>sharding-w8 flamegraph vs e0844966</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-limit-expressions/1ff54f5719c91d1c0c0e6...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-limit-express...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-limit-express...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-limit-express...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-limit-express...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-limit-express...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-limit-express...)
</details>

Compared 1ff54f57 with e0844966 on m7i.metal-48xl (spot).


view thread (10+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2030-c6849110180@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2030-c6849110180@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox