pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2040: perf: skip decode -> re-encode of subquery rows (binary DataRow -> binary array)
Date: Sun, 15 Nov 2026 00:57:39 +0000
Message-ID: <gh-pgdogdev-pgdog-2040-c6886959675@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2040@github.com>
References: <gh-pgdogdev-pgdog-2040@github.com>
<!-- metal-bench -->
**Metal bench (arm64) passed.** All 520 measures within bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 19.06 (+0.4% ± 0.4%) | 17,936 (-0.1% ± 0.4%) | 31,404 (-0.0% ± 0.03%) | 30,844 (+0.8% ± 1.2%) | 51,109 (-0.0% ± 0.3%) | |
| lb | | 19.5 (-0.7% ± 0.5%) | 18,568 (+0.8% ± 0.4%) | 32,321 (+0.0% ± 0.03%) | 31,132 (-1.5% ± 0.8%) | 52,255 (+0.1% ± 0.4%) | |
| sharding-w2 | | 32.33 (+0.4% ± 0.7%) | 43,351 (+0.2% ± 2.2%) | 94,899 (-0.0% ± 0.02%) | 40,706 (+0.8% ± 1.7%) | 53,719 (+0.0% ± 0.1%) | 1.549 (-0.0% ± 0.3%) |
| sharding-w8 | 244,588 (-0.3% ± 2.3%) | 29.27 (+0.5% ± 2.4%) | 44,500 (+0.4% ± 0.4%) | 50,471 (-0.0% ± 0.06%) | 36,357 (+0.6% ± 5.7%) | 42,371 (-0.0% ± 0.2%) | 0.168 (-0.6% ± 3.9%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,522 (-0.6% ± 1.1%) | 2,639 (-0.2% ± 0.5%) | |
| lb | 7,915 (+1.8% ± 1.3%) | 2,697 (+0.6% ± 0.7%) | |
| sharding-w2 | 17,603 (+0.3% ± 6.6%) | 4,125 (-0.1% ± 3.3%) | |
| sharding-w8 | 19,961 (-0.7% ± 1.0%) | 4,111 (-0.7% ± 0.9%) | |
</details>
Microbench: all 507 measures within bounds.
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 111.8 KB | 112.8 KB | **+1.1 KB** |
| sharding-w2 | 170.2 KB | 169.4 KB | **-0.8 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.1 KB | 20.1 KB | +0.0 KB |
| tokio | 18.2 KB | 18.3 KB | +0.1 KB |
| pgdog::backend::pool | 17.6 KB | 17.8 KB | +0.2 KB |
| aws-lc (TLS crypto) | 9.6 KB | 10.1 KB | +0.5 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | +0.0 KB |
| pgdog::frontend (other) | 7.8 KB | 7.9 KB | +0.1 KB |
| pgdog::backend::server | 7.6 KB | 7.7 KB | +0.1 KB |
| other | 5.9 KB | 6.1 KB | +0.2 KB |
| everything else | 16.7 KB | 16.6 KB | -0.1 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.6 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.1 KB | +0.0 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.1 KB | 29.2 KB | +0.2 KB |
| pgdog::frontend::client::query_engine | 21.9 KB | 21.6 KB | -0.3 KB |
| tokio | 19.2 KB | 18.9 KB | -0.3 KB |
| pgdog::backend::pool | 18.6 KB | 18.5 KB | -0.1 KB |
| aws-lc (TLS crypto) | 12.7 KB | 12.9 KB | +0.2 KB |
| other | 10.2 KB | 10.1 KB | -0.1 KB |
| pgdog::frontend (other) | 9.1 KB | 9.0 KB | -0.1 KB |
| rustls (TLS) | 8.1 KB | 8.4 KB | +0.2 KB |
| everything else | 41.4 KB | 40.8 KB | -0.6 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.5 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.1 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | -0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.4 KB | +0.1 KB |
</details>
<details><summary>lb flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...).
</details>
<details><summary>microbench flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...).
</details>
<details><summary>pooler flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...).
</details>
<details><summary>sharding-w2 flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...).
</details>
<details><summary>sharding-w8 flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-binary-conversion-subqueries/34ef3092...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-binary-conv...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-binary-conv...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-binary-conv...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-binary-conv...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-binary-conv...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-binary-conv...)
</details>
Compared 34ef3092 with 068e28fd on c8g.metal-24xl (on-demand).
view thread (6+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2040-c6886959675@github.com>
Permalink: ../gh-pgdogdev-pgdog-2040-c6886959675@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox