pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2040: perf: skip decode -> re-encode of subquery rows (binary DataRow -> binary array)
Date: Sun, 15 Nov 2026 00:59:18 +0000
Message-ID: <gh-pgdogdev-pgdog-2040-c6886977815@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2040@github.com>
References: <gh-pgdogdev-pgdog-2040@github.com>
<!-- metal-bench-x86 -->
**Metal bench (x86) passed.** All 520 measures within bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 34.97 (-0.0% ± 0.3%) | 22,913 (-0.0% ± 0.9%) | 32,718 (+0.0% ± 0.02%) | 58,401 (-0.1% ± 0.4%) | 38,539 (+0.1% ± 0.2%) | |
| lb | | 35.88 (-0.1% ± 0.3%) | 23,854 (+0.0% ± 1.0%) | 33,682 (-0.0% ± 0.03%) | 59,243 (-0.2% ± 0.2%) | 39,219 (-0.0% ± 0.1%) | |
| sharding-w2 | | 56.96 (-0.1% ± 1.4%) | 53,331 (-0.2% ± 2.2%) | 98,600 (+0.0% ± 0.06%) | 73,610 (+0.0% ± 1.6%) | 43,203 (+0.0% ± 0.05%) | 1.39 (+0.0% ± 0.5%) |
| sharding-w8 | 147,015 (+0.5% ± 1.9%) | 48.67 (-0.1% ± 1.6%) | 58,129 (-0.3% ± 0.7%) | 54,041 (-0.1% ± 0.2%) | 65,399 (+0.0% ± 2.9%) | 34,283 (-0.1% ± 0.3%) | 0.1684 (-0.1% ± 3.1%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 74,838 (-0.2% ± 1.0%) | 3,594 (+0.0% ± 0.2%) | |
| lb | 77,529 (+0.4% ± 0.8%) | 3,689 (+0.2% ± 0.2%) | |
| sharding-w2 | 163,003 (-0.7% ± 4.5%) | 6,079 (-0.1% ± 1.1%) | |
| sharding-w8 | 127,922 (-0.3% ± 1.9%) | 4,896 (-0.1% ± 0.3%) | |
</details>
Microbench: all 507 measures within bounds.
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 107.3 KB | 111.9 KB | **+4.6 KB** |
| sharding-w2 | 164.9 KB | 166.9 KB | **+2.0 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.8 KB | 21.8 KB | +0.9 KB |
| tokio | 17.4 KB | 17.9 KB | +0.5 KB |
| pgdog::backend::pool | 16.8 KB | 17.5 KB | +0.7 KB |
| pgdog::frontend (other) | 8.9 KB | 9.1 KB | +0.2 KB |
| pgdog::backend::server | 7.3 KB | 7.8 KB | +0.4 KB |
| aws-lc (TLS crypto) | 7.1 KB | 7.5 KB | +0.4 KB |
| rustls (TLS) | 7.1 KB | 7.3 KB | +0.2 KB |
| other | 5.6 KB | 5.8 KB | +0.2 KB |
| everything else | 16.3 KB | 17.2 KB | +0.9 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.0 KB | +0.3 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.6 KB | +0.3 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.6 KB | +0.4 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.8 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.6 KB | +0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 26.7 KB | 26.8 KB | +0.1 KB |
| pgdog::frontend::client::query_engine | 23.1 KB | 23.2 KB | +0.1 KB |
| tokio | 18.5 KB | 18.4 KB | -0.1 KB |
| pgdog::backend::pool | 17.8 KB | 18.3 KB | +0.5 KB |
| aws-lc (TLS crypto) | 10.1 KB | 10.4 KB | +0.3 KB |
| other | 10.7 KB | 10.3 KB | -0.4 KB |
| pgdog::frontend (other) | 10.2 KB | 10.2 KB | +0.0 KB |
| jemalloc | 8.8 KB | 9.6 KB | +0.8 KB |
| everything else | 39.0 KB | 39.8 KB | +0.8 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.8 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.3 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.6 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.2 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.0 KB |
</details>
<details><summary>lb flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...).
</details>
<details><summary>microbench flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...).
</details>
<details><summary>pooler flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...).
</details>
<details><summary>sharding-w2 flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...).
</details>
<details><summary>sharding-w8 flamegraph vs 068e28fd</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-binary-conversion-subqueries/34ef...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-binary-...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-binary-...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-binary-...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-binary-...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-binary-...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-binary-...)
</details>
Compared 34ef3092 with 068e28fd on c7a.metal-48xl (spot).
view thread (6+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2040-c6886977815@github.com>
Permalink: ../gh-pgdogdev-pgdog-2040-c6886977815@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox