pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS
Date: Wed, 18 Nov 2026 20:50:50 +0000
Message-ID: <gh-pgdogdev-pgdog-2042-c6991266373@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2042@github.com>
References: <gh-pgdogdev-pgdog-2042@github.com>
<!-- metal-bench -->
**Metal bench (arm64) passed.** All 520 measures within bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 18.92 (-0.6% ± 1.7%) | 18,219 (+0.4% ± 0.5%) | 31,413 (-0.0% ± 0.03%) | 30,114 (-1.4% ± 2.9%) | 51,066 (+0.0% ± 0.5%) | |
| lb | | 19.59 (-0.3% ± 0.7%) | 18,865 (+0.4% ± 0.8%) | 32,318 (+0.0% ± 0.05%) | 30,955 (-0.8% ± 1.3%) | 52,048 (-0.1% ± 0.2%) | |
| sharding-w2 | | 32.36 (+0.4% ± 1.4%) | 43,471 (+0.4% ± 1.5%) | 94,909 (-0.0% ± 0.02%) | 40,688 (+0.7% ± 1.2%) | 53,702 (-0.0% ± 0.6%) | 1.546 (-0.1% ± 0.1%) |
| sharding-w8 | 246,117 (-0.1% ± 1.6%) | 29.05 (+0.2% ± 1.9%) | 43,975 (+0.1% ± 2.5%) | 50,474 (+0.0% ± 0.01%) | 36,251 (+0.3% ± 2.5%) | 42,364 (-0.0% ± 0.10%) | 0.1695 (-0.5% ± 3.8%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,857 (+1.1% ± 1.1%) | 2,694 (+0.4% ± 0.5%) | |
| lb | 8,284 (+1.1% ± 2.3%) | 2,753 (+0.4% ± 1.2%) | |
| sharding-w2 | 17,830 (+1.2% ± 4.2%) | 4,141 (+0.5% ± 2.1%) | |
| sharding-w8 | 19,489 (+1.5% ± 6.5%) | 4,034 (+0.2% ± 3.8%) | |
</details>
Microbench: all 507 measures within bounds.
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 113.9 KB | 114.6 KB | **+0.7 KB** |
| sharding-w2 | 168.1 KB | 168.5 KB | **+0.4 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 19.9 KB | 20.1 KB | +0.2 KB |
| tokio | 18.6 KB | 18.3 KB | -0.2 KB |
| pgdog::backend::pool | 17.7 KB | 17.7 KB | +0.0 KB |
| aws-lc (TLS crypto) | 10.2 KB | 10.4 KB | +0.1 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | +0.0 KB |
| pgdog::frontend (other) | 7.9 KB | 7.9 KB | +0.0 KB |
| pgdog::backend::server | 7.9 KB | 7.8 KB | -0.2 KB |
| other | 6.0 KB | 6.4 KB | +0.4 KB |
| everything else | 17.3 KB | 17.8 KB | +0.4 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.5 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | -0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.2 KB | 29.2 KB | -0.1 KB |
| pgdog::frontend::client::query_engine | 21.1 KB | 21.0 KB | -0.1 KB |
| tokio | 18.1 KB | 18.6 KB | +0.4 KB |
| pgdog::backend::pool | 18.3 KB | 18.5 KB | +0.2 KB |
| aws-lc (TLS crypto) | 12.7 KB | 13.0 KB | +0.3 KB |
| other | 10.2 KB | 9.9 KB | -0.3 KB |
| pgdog::frontend (other) | 9.1 KB | 8.9 KB | -0.1 KB |
| rustls (TLS) | 8.1 KB | 8.2 KB | +0.1 KB |
| everything else | 41.2 KB | 41.2 KB | +0.0 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.4 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.1 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.0 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.2 KB | -0.1 KB |
</details>
<details><summary>lb flamegraph vs 34ef3092</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>microbench flamegraph vs 34ef3092</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>pooler flamegraph vs 34ef3092</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>sharding-w2 flamegraph vs 34ef3092</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>sharding-w8 flamegraph vs 34ef3092</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...)
</details>
Compared f59ca123 with 34ef3092 on c8g.metal-24xl (on-demand).
view thread (6+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2042-c6991266373@github.com>
Permalink: ../gh-pgdogdev-pgdog-2042-c6991266373@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox