pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
[pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS
6+ messages / 3 participants
[nested] [flat]

* [pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS
@ 2026-11-15 14:29 "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
  0 siblings, 0 replies; 6+ messages in thread

From: jkaczman (@jkaczman) @ 2026-11-15 14:29 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

Now that the subquery handling code is a bit more established after adding support for multiple clauses (CTEs, WHERE, INSERT .. SELECT, etc), it has grown to a point where the file is a bit cramped, especially considering that as more features are added (e.g., soon will support cross-shard joins), it will keep growing.

Thus, this now splits apart the mod.rs file in the execution and rewrite part of the code (in multi_step/subquery) to be three files (mod.rs, evaluate.rs, rewrite.rs).

mod.rs iterates through all subqueries, getting the queries to send from evaluate.rs, and after all results have been fetched for all subqueries, passes the results to rewrite.rs to rewrite the outer statement with them.

Additionally:
- The handling for the clauses is moved into a subfolder (used to be same level as mod.rs)
- WHERE EXISTS handling is tidied up, as we were special-casing it in two different places before (now it's just one)

No behavior change.

inline patch 1: pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/from_clause.rs, pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/insert_select.rs, pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/mod.rs and 5 more (+281/-247 lines) download inline-1.patchdiff --git a/pgdog/src/frontend/client/query_engine/multi_step/subquery/from_clause.rs b/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/from_clause.rs similarity index 99% rename from pgdog/src/frontend/client/query_engine/multi_step/subquery/from_clause.rs rename to pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/from_clause.rs index 549080241..374254b10 100644 --- a/pgdog/src/frontend/client/query_engine/multi_step/subquery/from_clause.rs +++ b/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/from_clause.rs @@ -158,7 +158,7 @@ impl<'a> SubqueryMulti<'a> { let pg_catalog_type: &str = data_type .into_array_type() - .expect("rewrite_outer_statement_with_subquery_response checked the column types") + .expect("evaluate_and_rewrite_outer_statement checked the column types") .as_pg_catalog_type(); let element_oid = data_type diff --git a/pgdog/src/frontend/client/query_engine/multi_step/subquery/insert_select.rs b/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/insert_select.rs similarity index 100% rename from pgdog/src/frontend/client/query_engine/multi_step/subquery/insert_select.rs rename to pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/insert_select.rs diff --git a/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/mod.rs b/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/mod.rs new file mode 100644 index 000000000..48be26ce7 --- /dev/null +++ b/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/mod.rs @@ -0,0 +1,6 @@ +//! Rewrites the outer statement for one kind of `Subquery` (one file per clause) + +mod from_clause; +mod insert_select; +mod where_clause; +mod with_clause; diff --git a/pgdog/src/frontend/client/query_engine/multi_step/subquery/where_clause.rs b/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/where_clause.rs similarity index 84% rename from pgdog/src/frontend/client/query_engine/multi_step/subquery/where_clause.rs rename to pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/where_clause.rs index 9f57727e8..bf598b7d4 100644 --- a/pgdog/src/frontend/client/query_engine/multi_step/subquery/where_clause.rs +++ b/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/where_clause.rs @@ -9,7 +9,10 @@ use pg_raw_parse::{ }; use crate::{ - frontend::{client::query_engine::multi_step::SubqueryMulti, router::parser::rewrite}, + frontend::{ + client::query_engine::multi_step::SubqueryMulti, + router::parser::rewrite::{self, statement::insert::Subquery}, + }, net::{Bind, DataRow, RowDescription}, }; @@ -67,6 +70,15 @@ impl<'a> SubqueryMulti<'a> { statement } + /// Returns true if `subquery` is the subquery of an EXISTS (..) in WHERE. + pub(crate) fn is_exists_in_where(&self, subquery: &Subquery) -> bool { + matches!(subquery, Subquery::WhereClause) + && rewrite::statement::subquery::where_clause::has_sub_link_in_where( + self.top_level_statement, + ) + .is_some_and(|(sublink, _)| sublink.sub_link_type == SubLinkType::EXISTS_SUBLINK) + } + fn rewrite_sublink_in_where_clause<'mem>( sublink: &SubLink, data_rows: &[DataRow], diff --git a/pgdog/src/frontend/client/query_engine/multi_step/subquery/with_clause.rs b/pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/with_clause.rs similarity index 100% rename from pgdog/src/frontend/client/query_engine/multi_step/subquery/with_clause.rs rename to pgdog/src/frontend/client/query_engine/multi_step/subquery/clause/with_clause.rs diff --git a/pgdog/src/frontend/client/query_engine/multi_step/subquery/evaluate.rs b/pgdog/src/frontend/client/query_engine/multi_step/subquery/evaluate.rs new file mode 100644 index 000000000..8ea094619 --- /dev/null +++ b/pgdog/src/frontend/client/query_engine/multi_step/subquery/evaluate.rs @@ -0,0 +1,167 @@ +//! Builds the SELECT that we send to the shards to evaluate a single `Subquery` (the first half of `evaluate_and_rewrite_outer_statement`) +//! +//! E.g., for SELECT * FROM orders WHERE user_id IN (SELECT id FROM users WHERE status = 'VIP'), +//! the `Subquery` is the SELECT inside IN (..), so we build +//! - SELECT id FROM users WHERE status = 'VIP' + +use pg_raw_parse::{ + Node, Owned, + make::{Unique, owned}, + nodes::{CommonTableExpr, SelectStmt}, +}; + +use crate::{ + frontend::{ + client::query_engine::multi_step::{Error, SubqueryMulti}, + router::parser::rewrite::statement::{ + insert::Subquery, + subquery::{ + from_clause::parse_from_clause, insert_select::parse_insert_select, + where_clause::parse_where_clause, with_clause::parse_with_clause, + }, + }, + }, + net::Bind, +}; + +impl<'ast> SubqueryMulti<'ast> { + /// Returns the SELECT that we send to the shards to fetch the rows of `subquery` (+ the Bind for that SELECT) + /// E.g., for .. WHERE user_id IN (SELECT id FROM users), we return SELECT id FROM users. + pub(super) fn new_select_to_fetch_rows_of_subquery( + &self, + subquery: &Subquery, + entire_ast: Node<'ast>, + ) -> Result<(Owned<SelectStmt>, Bind), Error> { + let subquery_ast: Node<'ast> = self.parse_out_relevant_query_to_send(subquery, entire_ast); + + // We might have to reference earlier statements and perform a re-write. E.g., if we have CTE b referencing CTE a, then we need to include the re-written CTE (w/ unnest) here + Ok(self.rewrite_subquery_ast_with_earlier_subquery_responses(subquery, subquery_ast)) + } + + /// Returns the SELECT of `subquery` inside `entire_ast`. E.g., + /// - for `Subquery::WhereClause` in .. WHERE id IN (SELECT id FROM users), we return SELECT id FROM users + /// - for `Subquery::Cte("a")` in WITH a AS (SELECT id FROM users) SELECT .., we return SELECT id FROM users + fn parse_out_relevant_query_to_send( + &self, + subquery: &Subquery, + entire_ast: Node<'ast>, + ) -> Node<'ast> { + match &subquery { + Subquery::FromClause => { + parse_from_clause(entire_ast) + } + Subquery::WhereClause => { + parse_where_clause(entire_ast) + } + Subquery::Cte(alias) => { + parse_with_clause(entire_ast, alias) + } + Subquery::InsertSelect => { + parse_insert_select(entire_ast) + } + Subquery::WhereClauseCte(alias) => { + parse_where_clause(entire_ast).and_then(|subselect| parse_with_clause(subselect, alias)) + } + }.expect("We already ran these methods in the parser originally. No reason they shouldn't pass here.") + } + + /// Adds the rows of the CTEs that we fetched before to `subquery_ast`, allowing `subquery_ast` to read those CTEs. E.g., for + /// - WITH a AS (SELECT id FROM users), b AS (SELECT id FROM a) SELECT .. + /// + /// the SELECT of CTE b reads CTE a. After we fetched CTE a, we return this to evaluate CTE b + /// - WITH a(id) AS (SELECT u.c1 FROM unnest($1::pg_catalog._int8) u(c1)) SELECT id FROM a + /// + /// with the rows of a as $1 in the returned Bind + fn rewrite_subquery_ast_with_earlier_subquery_responses( + &self, + subquery: &Subquery, + subquery_ast: Node<'ast>, + ) -> (Owned<SelectStmt>, Bind) { + let Node::SelectStmt(select) = subquery_ast else { + unreachable!("We only allow subselects to be subqueries"); + }; + + let mut subquery_bind = self.current_level_bind.clone(); + + let rewritten_subquery_ast = owned(|mem| { + let mut subquery_ast = mem.make_unique(select); + + // For INSERT .. SELECT, the WITH clause is attached to the INSERT + // --> e.g., WITH a AS (..) INSERT INTO orders SELECT .. FROM a + // + // However, We send the SELECT without the INSERT (to eval), so to properly + // eval the SELECT, we copy the WITH clause to the SELECT (as SELECT .. FROM a would fail without a) + if matches!(subquery, Subquery::InsertSelect) + && let Node::InsertStmt(insert) = self.top_level_statement + && let Some(with_clause) = insert.with_clause() + { + subquery_ast + .as_mut() + .set_with_clause(mem.make_unique(with_clause).as_option()); + } + + let mut previously_executed_ctes: Vec<Unique<&CommonTableExpr>> = Vec::new(); + + for (i, (rows, row_description)) in self.subquery_results.iter().enumerate() { + let subquery = self + .subqueries + .get(i) + .expect("Subquery 'i' must have existed to create the matching result"); + + match &subquery { + Subquery::Cte(alias) | Subquery::WhereClauseCte(alias) => { + let row_description = row_description + .as_ref() + .expect("RowDescription must be Some(..) in order to reach here"); + + // We need to set this within a WITH clause of the subselect, + // so that the subselect can reference previously ran CTEs + let new_cte_subselect = Self::new_select_with_unnest( + &mut subquery_bind, + mem, + Node::None, + rows, + row_description, + ); + + // Need to form the alias for the CTE to be referenced within the other CTE, + // so that it can reference <CTE>.<col> + let mut alias_col_names = Vec::new(); + for i in 0..row_description.len() { + alias_col_names.push( + mem.make_string(Some( + row_description.fields.get(i).unwrap().name.as_str(), + )) + .uncast(), + ); + } + + let new_cte = mem.make_common_table_expr( + alias, + mem.make_list(alias_col_names.as_slice()), + new_cte_subselect.uncast(), + ); + + previously_executed_ctes.push(new_cte); + } + + // For now, we'll only consider re-writing if it was previously a CTE. + _ => continue, + } + } + + if !previously_executed_ctes.is_empty() { + let new_with_clause = + mem.make_with_clause(mem.make_list(previously_executed_ctes.as_slice()), false); + + subquery_ast + .as_mut() + .set_with_clause(new_with_clause.as_option()); + } + + subquery_ast + }); + + (rewritten_subquery_ast, subquery_bind) + } +} diff --git a/pgdog/src/frontend/client/query_engine/multi_step/subquery/mod.rs b/pgdog/src/frontend/client/query_engine/multi_step/subquery/mod.rs index 27ebba953..073762588 100644 --- a/pgdog/src/frontend/client/query_engine/multi_step/subquery/mod.rs +++ b/pgdog/src/frontend/client/query_engine/multi_step/subquery/mod.rs @@ -5,32 +5,21 @@ use pg_raw_parse::{ Node, Owned, deparse, - make::{MemoryToken, Unique, owned}, - nodes::{CommonTableExpr, RawStmt, SelectStmt}, - raw::SubLinkType, + nodes::{RawStmt, SelectStmt}, }; // These are all internal modules; don't need to be exported out. -mod from_clause; -mod insert_select; +mod clause; +mod evaluate; mod request; -mod where_clause; -mod with_clause; +mod rewrite; use super::Error; use crate::{ frontend::{ ClientRequest, client::query_engine::{QueryEngine, QueryEngineContext, multi_step::error::SubqueryError}, - router::parser::rewrite::statement::{ - insert::Subquery, - subquery::{ - from_clause::parse_from_clause, - insert_select::parse_insert_select, - where_clause::{has_sub_link_in_where, parse_where_clause}, - with_clause::parse_with_clause, - }, - }, + router::parser::rewrite::statement::insert::Subquery, }, net::{Bind, DataRow, Format, ProtocolMessage, RowDescription}, }; @@ -177,7 +166,7 @@ impl<'ast> SubqueryMulti<'ast> { // Send the subquery that we parsed through the QueryEngine, and fetch its response back let (rewritten_subquery_ast, subquery_bind): (Owned<SelectStmt>, Bind) = - self.parse_and_rewrite_subquery_ast(subquery, current_statement)?; + self.new_select_to_fetch_rows_of_subquery(subquery, current_statement)?; let subquery_sql = deparse(&*rewritten_subquery_ast)?.as_str().to_string(); @@ -200,7 +189,8 @@ impl<'ast> SubqueryMulti<'ast> { results?.expect("send_query_string is only None when `is_subquery` is false"); // We send the rows of subqueries as unnest(..) arrays, so we check the column types before rewriting to ensure that all columns have array types. - if !matches!(subquery, Subquery::WhereClause) + // EXISTS is the only exception to this, since we only read whether or not the subquery returned rows (exists just needs 1 row to be replaced w/ TRUE) + if !self.is_exists_in_where(subquery) && let (_, Some(row_description)) = &results && row_description .fields @@ -235,234 +225,8 @@ impl<'ast> SubqueryMulti<'ast> { // Re-write outer statement with the response let (new_ast, new_bind): (Owned<RawStmt>, Bind) = - self.rewrite_outer_statement_with_subquery_response()?; + self.rewrite_outer_statement_with_subquery_response(); Ok((new_ast, new_bind)) } - - fn rewrite_subquery_ast_with_earlier_subquery_responses( - &self, - subquery: &Subquery, - subquery_ast: Node<'ast>, - ) -> (Owned<SelectStmt>, Bind) { - let Node::SelectStmt(select) = subquery_ast else { - unreachable!("We only allow subselects to be subqueries"); - }; - - let mut subquery_bind = self.current_level_bind.clone(); - - let rewritten_subquery_ast = owned(|mem| { - let mut subquery_ast = mem.make_unique(select); - - if matches!(subquery, Subquery::InsertSelect) - && let Node::InsertStmt(insert) = self.top_level_statement - && let Some(with_clause) = insert.with_clause() - { - subquery_ast - .as_mut() - .set_with_clause(mem.make_unique(with_clause).as_option()); - } - - let mut previously_executed_ctes: Vec<Unique<&CommonTableExpr>> = Vec::new(); - - for (i, (rows, row_description)) in self.subquery_results.iter().enumerate() { - let subquery = self - .subqueries - .get(i) - .expect("Subquery 'i' must have existed to create the matching result"); - - match &subquery { - Subquery::Cte(alias) | Subquery::WhereClauseCte(alias) => { - let row_description = row_description - .as_ref() - .expect("RowDescription must be Some(..) in order to reach here"); - - // We need to set this within a WITH clause of the subselect, - // so that the subselect can reference previously ran CTEs - let new_cte_subselect = Self::new_select_with_unnest( - &mut subquery_bind, - mem, - Node::None, - rows, - row_description, - ); - - // Need to form the alias for the CTE to be referenced within the other CTE, - // so that it can reference <CTE>.<col> - let mut alias_col_names = Vec::new(); - for i in 0..row_description.len() { - alias_col_names.push( - mem.make_string(Some( - row_description.fields.get(i).unwrap().name.as_str(), - )) - .uncast(), - ); - } - - let new_cte = mem.make_common_table_expr( - alias, - mem.make_list(alias_col_names.as_slice()), - new_cte_subselect.uncast(), - ); - - previously_executed_ctes.push(new_cte); - } - - // For now, we'll only consider re-writing if it was previously a CTE. - _ => continue, - } - } - - if !previously_executed_ctes.is_empty() { - let new_with_clause = - mem.make_with_clause(mem.make_list(previously_executed_ctes.as_slice()), false); - - subquery_ast - .as_mut() - .set_with_clause(new_with_clause.as_option()); - } - - subquery_ast - }); - - (rewritten_subquery_ast, subquery_bind) - } - - fn parse_and_rewrite_subquery_ast( - &self, - subquery: &Subquery, - entire_ast: Node<'ast>, - ) -> Result<(Owned<SelectStmt>, Bind), Error> { - let subquery_ast: Node<'ast> = self.parse_out_relevant_query_to_send(subquery, entire_ast); - - // We might have to reference earlier statements and perform a re-write. E.g., if we have CTE b referencing CTE a, then we need to include the re-written CTE (w/ unnest) here - // Only if it's actually relevant, but we need to either (a) figure that out somehow or (b) always include earlier ones - - Ok(self.rewrite_subquery_ast_with_earlier_subquery_responses(subquery, subquery_ast)) - } - - /// This is the relevant part of what we need to send, e.g., the subselect of a specific CTE. - fn parse_out_relevant_query_to_send( - &self, - subquery: &Subquery, - entire_ast: Node<'ast>, - ) -> Node<'ast> { - match &subquery { - Subquery::FromClause => { - parse_from_clause(entire_ast) - } - Subquery::WhereClause => { - parse_where_clause(entire_ast) - } - Subquery::Cte(alias) => { - parse_with_clause(entire_ast, alias) - } - Subquery::InsertSelect => { - parse_insert_select(entire_ast) - } - Subquery::WhereClauseCte(alias) => { - parse_where_clause(entire_ast).and_then(|subselect| parse_with_clause(subselect, alias)) - } - }.expect("We already ran these methods in the parser originally. No reason they shouldn't pass here.") - } - - fn rewrite_outer_statement_with_subquery_response( - &self, - ) -> Result<(Owned<RawStmt>, Bind), Error> { - // TODO(jkaczman): if we're always passing these three, might as well make a new type or - // hold these in the existing one - let mut new_bind = self.current_level_bind.clone(); - - // We send the rows of subqueries as unnest(..) arrays, so we check the column types before rewriting to ensure that all columns have array types. - for (subquery, (_, row_description)) in - self.subqueries.iter().zip(self.subquery_results.iter()) - { - // If we have an EXISTS_SUBLINK in WHERE, we don't send data back in the next round trip; instead, we replace the whole - // query with a boolean result. - let sends_rows_as_unnest_arrays = match subquery { - Subquery::WhereClause => has_sub_link_in_where(self.top_level_statement) - .is_some_and(|(sublink, _)| { - sublink.sub_link_type != SubLinkType::EXISTS_SUBLINK - }), - Subquery::FromClause - | Subquery::InsertSelect - | Subquery::Cte(_) - | Subquery::WhereClauseCte(_) => true, - }; - - if !sends_rows_as_unnest_arrays { - continue; - } - - let Some(row_description) = row_description else { - continue; - }; - - if row_description - .fields - .iter() - .find(|field| field.data_type().into_array_type().is_none()) - .is_some() - { - return Err(Error::Subquery( - SubqueryError::SubqueryReturningUnsupportedColumn, - )); - } - } - - let new_statement: Owned<RawStmt> = owned(|mem| { - let mut statement: Unique<'_, Node<'_>> = mem.make_unique(self.top_level_statement); - - // TODO(jkaczman): We'll either have to save the AST of the re-written node that we're - // constantly rewriting in this outer loop, or we can save it in the struct itself - // for easy reference.. however that'd mean we need a mutable reference to the struct, - // could be tricky when we try to parallelize this. - for (subquery, (data_rows, row_description)) in - self.subqueries.iter().zip(self.subquery_results.iter()) - { - statement = self.rewrite_with_subquery_response( - mem, - statement, - subquery, - row_description.as_ref(), - data_rows.as_slice(), - &mut new_bind, - ); - } - - // We also need to capture Bind parameters from this - - mem.make_raw_stmt(statement) - }); - - Ok((new_statement, new_bind)) - } - - fn rewrite_with_subquery_response<'mem>( - &self, - mem: MemoryToken<'mem>, - stmt: Unique<'mem, Node<'mem>>, - subquery: &Subquery, - row_description: Option<&RowDescription>, - data_rows: &[DataRow], - new_bind: &mut Bind, - ) -> Unique<'mem, Node<'mem>> { - match subquery { - Subquery::FromClause => { - self.handle_from_clause(mem, stmt, row_description, data_rows, new_bind) - } - Subquery::WhereClause => { - self.handle_where_clause(mem, stmt, row_description, data_rows, new_bind) - } - Subquery::InsertSelect => { - self.handle_insert_select(mem, stmt, row_description, data_rows, new_bind) - } - Subquery::WhereClauseCte(alias) => { - self.handle_where_clause_cte(alias, mem, stmt, row_description, data_rows, new_bind) - } - Subquery::Cte(alias) => { - self.handle_with_clause(alias, mem, stmt, row_description, data_rows, new_bind) - } - } - } } diff --git a/pgdog/src/frontend/client/query_engine/multi_step/subquery/rewrite.rs b/pgdog/src/frontend/client/query_engine/multi_step/subquery/rewrite.rs new file mode 100644 index 000000000..d00a72c52 --- /dev/null +++ b/pgdog/src/frontend/client/query_engine/multi_step/subquery/rewrite.rs @@ -0,0 +1,85 @@ +//! Rewrites the outer statement with the rows that the subqueries returned (the second half of `evaluate_and_rewrite_outer_statement`) +//! +//! E.g., for SELECT * FROM orders WHERE user_id IN (SELECT id FROM users WHERE status = 'VIP'), we rewrite the statement to +//! - SELECT * FROM orders WHERE user_id IN (SELECT u.c1 FROM unnest($1::pg_catalog._int8) u(c1)) +//! +//! with the ids that the subquery returned as $1 + +use pg_raw_parse::{ + Node, Owned, + make::{MemoryToken, Unique, owned}, + nodes::RawStmt, +}; + +use crate::{ + frontend::{ + client::query_engine::multi_step::SubqueryMulti, + router::parser::rewrite::statement::insert::Subquery, + }, + net::{Bind, DataRow, RowDescription}, +}; + +impl<'ast> SubqueryMulti<'ast> { + /// Returns the outer statement (& Bind for that statement) with the rows of all subqueries in place of the subqueries + pub(super) fn rewrite_outer_statement_with_subquery_response(&self) -> (Owned<RawStmt>, Bind) { + // TODO(jkaczman): if we're always passing these three, might as well make a new type or + // hold these in the existing one + let mut new_bind = self.current_level_bind.clone(); + + let new_statement: Owned<RawStmt> = owned(|mem| { + let mut statement: Unique<'_, Node<'_>> = mem.make_unique(self.top_level_statement); + + // TODO(jkaczman): We'll either have to save the AST of the re-written node that we're + // constantly rewriting in this outer loop, or we can save it in the struct itself + // for easy reference.. however that'd mean we need a mutable reference to the struct, + // could be tricky when we try to parallelize this. + for (subquery, (data_rows, row_description)) in + self.subqueries.iter().zip(self.subquery_results.iter()) + { + statement = self.rewrite_with_subquery_response( + mem, + statement, + subquery, + row_description.as_ref(), + data_rows.as_slice(), + &mut new_bind, + ); + } + + // We also need to capture Bind parameters from this + + mem.make_raw_stmt(statement) + }); + + (new_statement, new_bind) + } + + /// Puts the rows of `subquery` (`data_rows`) in place of `subquery` in `stmt`. + fn rewrite_with_subquery_response<'mem>( + &self, + mem: MemoryToken<'mem>, + stmt: Unique<'mem, Node<'mem>>, + subquery: &Subquery, + row_description: Option<&RowDescription>, + data_rows: &[DataRow], + new_bind: &mut Bind, + ) -> Unique<'mem, Node<'mem>> { + match subquery { + Subquery::FromClause => { + self.handle_from_clause(mem, stmt, row_description, data_rows, new_bind) + } + Subquery::WhereClause => { + self.handle_where_clause(mem, stmt, row_description, data_rows, new_bind) + } + Subquery::InsertSelect => { + self.handle_insert_select(mem, stmt, row_description, data_rows, new_bind) + } + Subquery::WhereClauseCte(alias) => { + self.handle_where_clause_cte(alias, mem, stmt, row_description, data_rows, new_bind) + } + Subquery::Cte(alias) => { + self.handle_with_clause(alias, mem, stmt, row_description, data_rows, new_bind) + } + } + } +}
^ permalink raw [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS
@ 2026-11-18 20:10 ` "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: codecov[bot] (bot) (@codecov[bot]) @ 2026-11-18 20:10 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

## [Codecov](https://app.codecov.io/gh/pgdogdev/pgdog/pull/2042?dropdown=coverage&src=pr&el=h1&utm_me...) Report
:x: Patch coverage is `72.18045%` with `37 lines` in your changes missing coverage. Please review.
| [Files with missing lines](https://app.codecov.io/gh/pgdogdev/pgdog/pull/2042?dropdown=coverage&src=pr&el=tree&utm_...) | Patch % | Lines |
|---|---|---|
| [...lient/query\_engine/multi\_step/subquery/evaluate.rs](https://app.codecov.io/gh/pgdogdev/pgdog/pull/2042?src=pr&el=tree&utm_medium=referral&ut...) | 56.47% | [37 Missing :warning: ](https://app.codecov.io/gh/pgdogdev/pgdog/pull/2042?src=pr&el=tree&utm_medium=referral&ut...) |

:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/255)

^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS
@ 2026-11-18 20:50 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: github-actions[bot] (bot) (@github-actions[bot]) @ 2026-11-18 20:50 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

<!-- metal-bench -->

**Metal bench (arm64) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 18.92 (-0.6% ± 1.7%) | 18,219 (+0.4% ± 0.5%) | 31,413 (-0.0% ± 0.03%) | 30,114 (-1.4% ± 2.9%) | 51,066 (+0.0% ± 0.5%) |  |
| lb |  | 19.59 (-0.3% ± 0.7%) | 18,865 (+0.4% ± 0.8%) | 32,318 (+0.0% ± 0.05%) | 30,955 (-0.8% ± 1.3%) | 52,048 (-0.1% ± 0.2%) |  |
| sharding-w2 |  | 32.36 (+0.4% ± 1.4%) | 43,471 (+0.4% ± 1.5%) | 94,909 (-0.0% ± 0.02%) | 40,688 (+0.7% ± 1.2%) | 53,702 (-0.0% ± 0.6%) | 1.546 (-0.1% ± 0.1%) |
| sharding-w8 | 246,117 (-0.1% ± 1.6%) | 29.05 (+0.2% ± 1.9%) | 43,975 (+0.1% ± 2.5%) | 50,474 (+0.0% ± 0.01%) | 36,251 (+0.3% ± 2.5%) | 42,364 (-0.0% ± 0.10%) | 0.1695 (-0.5% ± 3.8%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,857 (+1.1% ± 1.1%) | 2,694 (+0.4% ± 0.5%) |  |
| lb | 8,284 (+1.1% ± 2.3%) | 2,753 (+0.4% ± 1.2%) |  |
| sharding-w2 | 17,830 (+1.2% ± 4.2%) | 4,141 (+0.5% ± 2.1%) |  |
| sharding-w8 | 19,489 (+1.5% ± 6.5%) | 4,034 (+0.2% ± 3.8%) |  |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 113.9 KB | 114.6 KB | **+0.7 KB** |
| sharding-w2 | 168.1 KB | 168.5 KB | **+0.4 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 19.9 KB | 20.1 KB | +0.2 KB |
| tokio | 18.6 KB | 18.3 KB | -0.2 KB |
| pgdog::backend::pool | 17.7 KB | 17.7 KB | +0.0 KB |
| aws-lc (TLS crypto) | 10.2 KB | 10.4 KB | +0.1 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | +0.0 KB |
| pgdog::frontend (other) | 7.9 KB | 7.9 KB | +0.0 KB |
| pgdog::backend::server | 7.9 KB | 7.8 KB | -0.2 KB |
| other | 6.0 KB | 6.4 KB | +0.4 KB |
| everything else | 17.3 KB | 17.8 KB | +0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.5 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | -0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.2 KB | 29.2 KB | -0.1 KB |
| pgdog::frontend::client::query_engine | 21.1 KB | 21.0 KB | -0.1 KB |
| tokio | 18.1 KB | 18.6 KB | +0.4 KB |
| pgdog::backend::pool | 18.3 KB | 18.5 KB | +0.2 KB |
| aws-lc (TLS crypto) | 12.7 KB | 13.0 KB | +0.3 KB |
| other | 10.2 KB | 9.9 KB | -0.3 KB |
| pgdog::frontend (other) | 9.1 KB | 8.9 KB | -0.1 KB |
| rustls (TLS) | 8.1 KB | 8.2 KB | +0.1 KB |
| everything else | 41.2 KB | 41.2 KB | +0.0 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.4 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.1 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.0 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.2 KB | -0.1 KB |

</details>

<details><summary>lb flamegraph vs 34ef3092</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>microbench flamegraph vs 34ef3092</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>pooler flamegraph vs 34ef3092</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>sharding-w2 flamegraph vs 34ef3092</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>
<details><summary>sharding-w8 flamegraph vs 34ef3092</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-subquery-refactor/f59ca123729d916b8492ccbfc9cb...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-subquery-refactor/f5...)
</details>

Compared f59ca123 with 34ef3092 on c8g.metal-24xl (on-demand).


^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS
@ 2026-11-18 22:02 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: github-actions[bot] (bot) (@github-actions[bot]) @ 2026-11-18 22:02 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 25.81 (-0.0% ± 0.3%) | 18,828 (+0.2% ± 0.4%) | 32,760 (+0.3% ± 0.8%) | 33,431 (-0.2% ± 0.3%) | 36,385 (-0.3% ± 0.5%) |  |
| lb |  | 26.29 (+0.1% ± 0.4%) | 19,465 (+0.0% ± 0.1%) | 33,742 (-0.0% ± 0.03%) | 33,704 (+0.1% ± 0.8%) | 37,265 (+0.0% ± 0.4%) |  |
| sharding-w2 |  | 41.85 (-0.1% ± 0.7%) | 47,147 (-0.3% ± 0.4%) | 98,596 (-0.0% ± 0.03%) | 38,189 (+0.2% ± 2.2%) | 40,144 (+0.0% ± 0.08%) | 1.53 (+0.0% ± 0.2%) |
| sharding-w8 | 205,264 (-0.1% ± 0.8%) | 33.04 (+0.1% ± 0.6%) | 46,066 (+0.1% ± 0.8%) | 52,956 (+0.0% ± 0.03%) | 31,476 (+0.1% ± 0.4%) | 32,558 (+0.0% ± 0.05%) | 0.1746 (+0.1% ± 1.2%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 3,655 (-0.0% ± 0.5%) | 1,126 (-0.5% ± 0.6%) | 38,215 (+0.2% ± 0.8%) |
| lb | 3,956 (+0.0% ± 0.7%) | 1,176 (-0.1% ± 1.5%) | 38,534 (-0.1% ± 0.6%) |
| sharding-w2 | 6,935 (-0.2% ± 0.7%) | 1,590 (-0.0% ± 0.8%) | 111,841 (-0.6% ± 1.0%) |
| sharding-w8 | 3,598 (+0.2% ± 1.3%) | 932 (+0.2% ± 1.2%) | 177,280 (+0.2% ± 1.4%) |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 113.9 KB | 114.1 KB | **+0.1 KB** |
| sharding-w2 | 168.6 KB | 168.1 KB | **-0.6 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 22.2 KB | 22.3 KB | +0.1 KB |
| tokio | 18.4 KB | 18.7 KB | +0.3 KB |
| pgdog::backend::pool | 18.2 KB | 18.4 KB | +0.2 KB |
| pgdog::frontend (other) | 9.2 KB | 9.2 KB | -0.1 KB |
| aws-lc (TLS crypto) | 8.8 KB | 8.4 KB | -0.3 KB |
| pgdog::backend::server | 8.1 KB | 8.1 KB | +0.0 KB |
| rustls (TLS) | 7.8 KB | 7.7 KB | -0.1 KB |
| other | 5.8 KB | 6.0 KB | +0.2 KB |
| everything else | 15.6 KB | 15.2 KB | -0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.1 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.5 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.6 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.7 KB | +0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 27.8 KB | 28.1 KB | +0.2 KB |
| pgdog::frontend::client::query_engine | 23.7 KB | 23.8 KB | +0.1 KB |
| pgdog::backend::pool | 19.2 KB | 19.1 KB | -0.1 KB |
| tokio | 18.6 KB | 18.4 KB | -0.2 KB |
| other | 10.6 KB | 10.8 KB | +0.2 KB |
| pgdog::frontend (other) | 10.8 KB | 10.6 KB | -0.2 KB |
| aws-lc (TLS crypto) | 9.9 KB | 9.7 KB | -0.2 KB |
| pgdog::backend::server | 8.8 KB | 8.8 KB | +0.0 KB |
| everything else | 39.2 KB | 38.9 KB | -0.3 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 8.1 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.6 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.6 KB | +0.0 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.1 KB | -0.2 KB |
| `tokio::runtime::task::raw::poll` | 3.9 KB | -0.2 KB |

</details>

<details><summary>lb flamegraph vs 34ef3092</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...).
</details>
<details><summary>microbench flamegraph vs 34ef3092</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...).
</details>
<details><summary>pooler flamegraph vs 34ef3092</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...).
</details>
<details><summary>sharding-w2 flamegraph vs 34ef3092</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...).
</details>
<details><summary>sharding-w8 flamegraph vs 34ef3092</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-subquery-refactor/f59ca123729d916b8492ccbf...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-refacto...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-refacto...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-refacto...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-refacto...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-refacto...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-subquery-refacto...)
</details>

Compared f59ca123 with 34ef3092 on c7i.metal-48xl (on-demand).


^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS
@ 2026-11-18 22:49 ` "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: jkaczman (@jkaczman) @ 2026-11-18 22:49 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

@jkaczman merged this (commit 7c0056052979).

^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS
@ 2026-11-18 22:49 ` "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: jkaczman (@jkaczman) @ 2026-11-18 22:49 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

@jkaczman closed this.

^ permalink  raw  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2026-11-18 22:49 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-15 14:29 [pgdogdev/pgdog] PR #2042: refactor: split multi_step/subquery/mod.rs + subfolder for clause handling + clean up WHERE EXISTS "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
2026-11-18 20:10 ` "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
2026-11-18 20:50 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
2026-11-18 22:02 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
2026-11-18 22:49 ` "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
2026-11-18 22:49 ` "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox