pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2050: feat: cross-shard GROUP BY on SELECT aliases, and alias/expression keys with HAVING
Date: Tue, 17 Nov 2026 17:41:05 +0000
Message-ID: <gh-pgdogdev-pgdog-2050-c6956004461@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2050@github.com>
References: <gh-pgdogdev-pgdog-2050@github.com>

<!-- metal-bench -->

**Metal bench (arm64) failed.** 5 of 520 measures outside bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 19.02 (-0.1% ± 2.5%) | 17,950 (+0.2% ± 1.2%) | 31,403 (-0.0% ± 0.10%) | 30,733 (-0.2% ± 5.0%) | 51,020 (-0.0% ± 0.3%) |  |
| lb |  | 19.66 (+0.1% ± 1.5%) | 18,627 (+0.3% ± 1.1%) | 32,315 (-0.0% ± 0.03%) | 31,509 (-0.2% ± 2.7%) | 52,139 (-0.1% ± 0.4%) |  |
| sharding-w2 |  | 32.14 (+0.2% ± 1.2%) | 43,493 (+0.0% ± 1.2%) | 94,929 (+0.0% ± 0.01%) | 40,047 (+0.6% ± 2.2%) | 53,712 (-0.0% ± 0.1%) | 1.548 (-0.0% ± 0.2%) |
| sharding-w8 | 248,256 (+0.0% ± 2.3%) | 28.75 (+0.0% ± 2.6%) | 44,564 (+0.6% ± 0.7%) | 50,475 (+0.0% ± 0.2%) | 34,809 (-0.8% ± 5.4%) | 42,363 (-0.0% ± 0.1%) | 0.1705 (-0.7% ± 3.7%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,536 (+0.8% ± 2.8%) | 2,647 (+0.1% ± 1.1%) |  |
| lb | 8,016 (+1.2% ± 3.0%) | 2,715 (+0.4% ± 1.3%) |  |
| sharding-w2 | 17,897 (+0.4% ± 2.8%) | 4,162 (+0.5% ± 2.0%) |  |
| sharding-w8 | 20,075 (+0.1% ± 1.3%) | 4,132 (-0.1% ± 1.6%) |  |
</details>

| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| extended_cached::aggregate | instructions | 17,667 | 17,403 | **+1.52% ± 0.00%** | +1% |
| extended_cold::begin | instructions | 11,325 | 11,088 | **+2.14% ± 0.00%** | +1% |
| extended_cold::set | instructions | 15,171 | 14,722 | **+3.05% ± 0.00%** | +1% |
| full_named_cached::aggregate | instructions | 136,288 | 134,359 | **+1.44% ± 0.00%** | +1% |
| full_named_cached::order_limit_offset | instructions | 185,783 | 182,864 | **+1.60% ± 0.00%** | +1% |

Microbench: 502 of 507 measures within bounds.

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 113.1 KB | 113.9 KB | **+0.8 KB** |
| sharding-w2 | 169.3 KB | 167.8 KB | **-1.5 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 19.7 KB | 20.2 KB | +0.5 KB |
| tokio | 18.5 KB | 18.4 KB | -0.1 KB |
| pgdog::backend::pool | 17.8 KB | 17.5 KB | -0.2 KB |
| aws-lc (TLS crypto) | 10.1 KB | 10.1 KB | +0.0 KB |
| rustls (TLS) | 8.3 KB | 8.4 KB | +0.1 KB |
| pgdog::frontend (other) | 7.8 KB | 8.0 KB | +0.2 KB |
| pgdog::backend::server | 7.8 KB | 7.8 KB | -0.1 KB |
| other | 5.8 KB | 6.3 KB | +0.6 KB |
| everything else | 17.4 KB | 17.2 KB | -0.2 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.6 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.1 KB | -0.2 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.4 KB | 29.2 KB | -0.2 KB |
| pgdog::frontend::client::query_engine | 21.2 KB | 21.0 KB | -0.2 KB |
| tokio | 18.7 KB | 18.5 KB | -0.2 KB |
| pgdog::backend::pool | 18.4 KB | 18.2 KB | -0.2 KB |
| aws-lc (TLS crypto) | 13.2 KB | 13.1 KB | -0.1 KB |
| other | 10.0 KB | 10.2 KB | +0.2 KB |
| pgdog::frontend (other) | 9.1 KB | 9.1 KB | +0.0 KB |
| rustls (TLS) | 8.1 KB | 8.2 KB | +0.1 KB |
| everything else | 41.2 KB | 40.4 KB | -0.8 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.1 KB | +0.0 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.9 KB | +0.6 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 3.9 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.3 KB | +0.1 KB |

</details>

<details><summary>lb flamegraph vs 0eda9a90</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...).
</details>
<details><summary>microbench flamegraph vs 0eda9a90</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...).
</details>
<details><summary>pooler flamegraph vs 0eda9a90</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...).
</details>
<details><summary>sharding-w2 flamegraph vs 0eda9a90</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...).
</details>
<details><summary>sharding-w8 flamegraph vs 0eda9a90</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-group-by-alias/6d5f51818ae7f85fa74910bb93f4...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-group-by-alias/6d...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-group-by-alias/6d...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-group-by-alias/6d...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-group-by-alias/6d...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-group-by-alias/6d...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-group-by-alias/6d...)
</details>

Compared 6d5f5181 with 0eda9a90 on m8g.metal-24xl (spot).


view thread (8+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2050-c6956004461@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2050-c6956004461@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox