pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2050: feat: cross-shard GROUP BY on SELECT aliases, and alias/expression keys with HAVING
Date: Tue, 17 Nov 2026 17:42:43 +0000
Message-ID: <gh-pgdogdev-pgdog-2050-c6956043212@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2050@github.com>
References: <gh-pgdogdev-pgdog-2050@github.com>
<!-- metal-bench-x86 -->
**Metal bench (x86) failed.** 3 of 520 measures outside bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 34.77 (+0.1% ± 0.2%) | 23,014 (+0.3% ± 0.4%) | 32,727 (-0.0% ± 0.02%) | 57,966 (+0.0% ± 0.5%) | 38,572 (-0.0% ± 0.3%) | |
| lb | | 35.81 (+0.0% ± 0.3%) | 24,242 (+0.0% ± 1.3%) | 33,687 (-0.0% ± 0.03%) | 58,945 (-0.0% ± 0.3%) | 39,199 (+0.0% ± 0.2%) | |
| sharding-w2 | | 56.42 (+0.2% ± 1.3%) | 53,368 (+0.7% ± 1.6%) | 98,582 (+0.0% ± 0.01%) | 72,963 (+0.0% ± 1.9%) | 43,083 (-0.0% ± 0.8%) | 1.39 (-0.1% ± 0.4%) |
| sharding-w8 | 147,151 (-0.1% ± 3.1%) | 48.64 (+0.3% ± 2.3%) | 58,048 (-0.1% ± 0.8%) | 54,061 (+0.0% ± 0.2%) | 65,538 (+0.6% ± 4.3%) | 34,230 (-0.0% ± 0.3%) | 0.1711 (+0.9% ± 3.6%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 74,526 (+0.4% ± 0.6%) | 3,661 (-0.1% ± 0.09%) | |
| lb | 77,641 (-0.1% ± 1.6%) | 3,795 (-0.1% ± 0.2%) | |
| sharding-w2 | 162,484 (+1.1% ± 4.4%) | 6,199 (+1.7% ± 0.8%) | |
| sharding-w8 | 124,392 (+0.8% ± 3.8%) | 5,049 (+1.4% ± 0.5%) | |
</details>
| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| full_named_cached::aggregate | instructions | 143,248 | 140,659 | **+1.84% ± 0.00%** | +1% |
| full_named_cached::order_limit_offset | instructions | 199,167 | 194,907 | **+2.19% ± 0.00%** | +1% |
| simple_cold::set | instructions | 13,644 | 13,367 | **+2.07% ± 0.00%** | +1% |
Microbench: 504 of 507 measures within bounds.
<details><summary>Microbench latency: 1 benches changed more than 3%</summary>
| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::having | 3,069 ns | 2,976 ns | +3.13% ± 0.36% | +0.07% ± 0.00% |
</details>
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 107.4 KB | 110.2 KB | **+2.8 KB** |
| sharding-w2 | 165.1 KB | 167.5 KB | **+2.4 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 21.2 KB | 21.9 KB | +0.6 KB |
| tokio | 17.6 KB | 17.8 KB | +0.2 KB |
| pgdog::backend::pool | 16.6 KB | 17.2 KB | +0.6 KB |
| pgdog::frontend (other) | 9.1 KB | 8.9 KB | -0.2 KB |
| pgdog::backend::server | 7.2 KB | 7.8 KB | +0.5 KB |
| aws-lc (TLS crypto) | 7.1 KB | 7.6 KB | +0.6 KB |
| rustls (TLS) | 6.9 KB | 7.0 KB | +0.1 KB |
| other | 5.6 KB | 5.9 KB | +0.3 KB |
| everything else | 16.1 KB | 16.1 KB | +0.1 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.8 KB | -0.3 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.8 KB | +0.4 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.6 KB | +0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 26.4 KB | 27.6 KB | +1.1 KB |
| pgdog::frontend::client::query_engine | 23.4 KB | 23.4 KB | +0.0 KB |
| pgdog::backend::pool | 18.4 KB | 18.9 KB | +0.4 KB |
| tokio | 18.2 KB | 18.6 KB | +0.4 KB |
| other | 10.4 KB | 10.6 KB | +0.2 KB |
| aws-lc (TLS crypto) | 9.8 KB | 10.4 KB | +0.6 KB |
| pgdog::frontend (other) | 10.2 KB | 9.9 KB | -0.2 KB |
| jemalloc | 8.9 KB | 8.8 KB | -0.1 KB |
| everything else | 39.4 KB | 39.4 KB | +0.0 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.5 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.6 KB | +0.0 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.4 KB | +0.5 KB |
| `tokio::runtime::task::raw::poll` | 3.9 KB | +0.1 KB |
</details>
<details><summary>lb flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...).
</details>
<details><summary>microbench flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...).
</details>
<details><summary>pooler flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...).
</details>
<details><summary>sharding-w2 flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...).
</details>
<details><summary>sharding-w8 flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-group-by-alias/6d5f51818ae7f85fa74910bb...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-group-by-alia...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-group-by-alia...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-group-by-alia...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-group-by-alia...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-group-by-alia...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-group-by-alia...)
</details>
Compared 6d5f5181 with 0eda9a90 on c7a.metal-48xl (spot).
view thread (8+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2050-c6956043212@github.com>
Permalink: ../gh-pgdogdev-pgdog-2050-c6956043212@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox