pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2058: feat(resharding): add initial setup for resumable resharding tasks
Date: Wed, 18 Nov 2026 13:52:53 +0000
Message-ID: <gh-pgdogdev-pgdog-2058-c6980583021@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2058@github.com>
References: <gh-pgdogdev-pgdog-2058@github.com>
<!-- metal-bench-x86 -->
**Metal bench (x86) passed.** All 520 measures within bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 34.75 (+0.2% ± 0.3%) | 23,051 (+0.3% ± 1.3%) | 32,727 (+0.0% ± 0.02%) | 57,831 (+0.2% ± 0.2%) | 38,553 (-0.0% ± 0.2%) | |
| lb | | 35.7 (+0.1% ± 0.09%) | 24,161 (-0.0% ± 0.9%) | 33,690 (-0.0% ± 0.02%) | 58,695 (+0.1% ± 0.3%) | 39,219 (-0.0% ± 0.10%) | |
| sharding-w2 | | 56.85 (+0.5% ± 1.0%) | 53,398 (+0.6% ± 1.2%) | 98,592 (+0.0% ± 0.07%) | 73,706 (+0.5% ± 1.4%) | 43,126 (-0.0% ± 0.2%) | 1.388 (-0.2% ± 0.09%) |
| sharding-w8 | 145,204 (-1.0% ± 3.2%) | 48.77 (+0.2% ± 1.3%) | 58,595 (+0.2% ± 0.8%) | 54,096 (+0.1% ± 0.2%) | 65,302 (+0.3% ± 3.1%) | 34,262 (-0.1% ± 0.5%) | 0.1679 (-1.2% ± 0.3%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 75,483 (-0.1% ± 1.3%) | 3,701 (-0.1% ± 0.2%) | |
| lb | 79,494 (-0.2% ± 1.2%) | 3,814 (-0.1% ± 0.2%) | |
| sharding-w2 | 165,103 (+1.3% ± 2.5%) | 6,171 (+1.3% ± 0.8%) | |
| sharding-w8 | 128,516 (-0.4% ± 2.7%) | 5,044 (+0.5% ± 0.4%) | |
</details>
Microbench: all 507 measures within bounds.
<details><summary>Microbench latency: 47 benches changed more than 3%</summary>
| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cold::delete_by_key | 3,958 ns | 3,750 ns | +5.55% ± 1.09% | +0.01% ± 0.00% |
| extended_evicting::delete_all_shards | 3,162 ns | 2,999 ns | +5.44% ± 1.32% | +0.00% ± 0.00% |
| extended_cold::delete_all_shards | 3,039 ns | 2,883 ns | +5.41% ± 0.49% | +0.00% ± 0.00% |
| extended_cold::begin | 2,073 ns | 1,969 ns | +5.28% ± 0.34% | +0.00% ± 0.00% |
| simple_cold::begin | 1,957 ns | 1,860 ns | +5.22% ± 1.74% | +0.00% ± 0.00% |
| full_simple::update_by_key | 11,348 ns | 10,794 ns | +5.14% ± 0.97% | +0.00% ± 0.00% |
| extended_evicting::begin | 2,239 ns | 2,131 ns | +5.07% ± 1.17% | +0.00% ± 0.00% |
| extended_cold::update_by_key | 4,556 ns | 4,338 ns | +5.03% ± 0.47% | +0.01% ± 0.00% |
| simple_cold::update_all_shards | 3,565 ns | 3,399 ns | +4.88% ± 0.51% | +0.00% ± 0.00% |
| full_simple::delete_by_key | 10,628 ns | 10,136 ns | +4.85% ± 0.62% | +0.00% ± 0.00% |
| simple_cold::delete_all_shards | 2,897 ns | 2,765 ns | +4.78% ± 1.11% | +0.00% ± 0.00% |
| simple_cold::delete_by_key | 3,826 ns | 3,652 ns | +4.77% ± 1.17% | +0.01% ± 0.00% |
| extended_evicting::delete_by_key | 4,096 ns | 3,910 ns | +4.76% ± 0.87% | +0.01% ± 0.00% |
| simple_cold::update_by_key | 4,410 ns | 4,212 ns | +4.70% ± 1.02% | +0.01% ± 0.00% |
| simple_cold::set | 2,514 ns | 2,402 ns | +4.66% ± 0.86% | +0.00% ± 0.00% |
| extended_cold::update_all_shards | 3,677 ns | 3,515 ns | +4.61% ± 0.47% | +0.00% ± 0.00% |
| full_simple::delete_all_shards | 13,438 ns | 12,852 ns | +4.57% ± 1.97% | +0.00% ± 0.00% |
| full_simple::update_all_shards | 14,174 ns | 13,560 ns | +4.53% ± 0.98% | +0.00% ± 0.00% |
| extended_cold::lookup | 17,728 ns | 16,970 ns | +4.47% ± 1.22% | +0.10% ± 0.00% |
| simple_cold::select_omni | 3,603 ns | 3,449 ns | +4.47% ± 1.14% | +0.00% ± 0.00% |
| extended_evicting::lookup | 5,672 ns | 5,430 ns | +4.46% ± 0.58% | +0.01% ± 0.00% |
| simple_cold::lookup | 17,552 ns | 16,822 ns | +4.34% ± 0.55% | +0.10% ± 0.00% |
| extended_cold::select_omni | 3,743 ns | 3,589 ns | +4.29% ± 0.56% | +0.00% ± 0.00% |
| extended_cold::select_all_shards | 4,084 ns | 3,926 ns | +4.03% ± 0.58% | +0.00% ± 0.00% |
| extended_cold::select_by_key | 4,983 ns | 4,793 ns | +3.96% ± 0.33% | +0.01% ± 0.00% |
| extended_evicting::update_by_key | 4,686 ns | 4,508 ns | +3.95% ± 0.61% | +0.01% ± 0.00% |
| simple_cold::select_by_key | 4,860 ns | 4,676 ns | +3.94% ± 1.24% | +0.01% ± 0.00% |
| simple_cold::select_in_list | 5,835 ns | 5,615 ns | +3.92% ± 1.28% | +0.01% ± 0.00% |
| extended_evicting::update_all_shards | 3,829 ns | 3,685 ns | +3.92% ± 1.49% | +0.00% ± 0.00% |
| extended_cold::set | 2,622 ns | 2,524 ns | +3.88% ± 0.23% | +0.00% ± 0.00% |
| simple_cold::select_all_shards | 3,963 ns | 3,817 ns | +3.83% ± 1.39% | +0.00% ± 0.00% |
| full_simple::insert | 13,386 ns | 12,898 ns | +3.79% ± 1.56% | +0.00% ± 0.00% |
| extended_evicting::select_omni | 3,919 ns | 3,782 ns | +3.62% ± 0.91% | +0.00% ± 0.00% |
| full_simple::insert_returning | 15,038 ns | 14,520 ns | +3.57% ± 1.04% | +0.00% ± 0.00% |
| extended_cold::distinct | 4,378 ns | 4,228 ns | +3.56% ± 1.47% | +0.00% ± 0.00% |
| extended_evicting::join | 7,739 ns | 7,479 ns | +3.48% ± 0.24% | +0.01% ± 0.00% |
| full_simple::insert_split | 21,978 ns | 21,254 ns | +3.41% ± 0.97% | +0.00% ± 0.00% |
| full_simple::aggregate | 27,776 ns | 26,868 ns | +3.39% ± 1.71% | +0.00% ± 0.00% |
| simple_cold::having | 16,880 ns | 16,350 ns | +3.25% ± 1.21% | +0.00% ± 0.00% |
| simple_cold::order_limit_offset | 8,134 ns | 7,879 ns | +3.24% ± 0.61% | -0.02% ± 0.00% |
</details>
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 110.7 KB | 112.2 KB | **+1.6 KB** |
| sharding-w2 | 167.2 KB | 167.2 KB | **-0.1 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 21.6 KB | 21.8 KB | +0.2 KB |
| tokio | 17.8 KB | 17.8 KB | -0.1 KB |
| pgdog::backend::pool | 17.1 KB | 17.2 KB | +0.2 KB |
| pgdog::frontend (other) | 8.9 KB | 9.1 KB | +0.1 KB |
| pgdog::backend::server | 7.4 KB | 7.7 KB | +0.3 KB |
| aws-lc (TLS crypto) | 6.9 KB | 7.4 KB | +0.6 KB |
| rustls (TLS) | 6.5 KB | 7.1 KB | +0.6 KB |
| other | 6.4 KB | 6.5 KB | +0.1 KB |
| everything else | 18.1 KB | 17.6 KB | -0.4 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.9 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.6 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.4 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.2 KB |
| `tokio::runtime::task::raw::poll` | 3.6 KB | -0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 27.7 KB | 27.6 KB | -0.1 KB |
| pgdog::frontend::client::query_engine | 23.2 KB | 22.9 KB | -0.2 KB |
| pgdog::backend::pool | 18.3 KB | 18.9 KB | +0.6 KB |
| tokio | 18.1 KB | 17.9 KB | -0.2 KB |
| other | 11.1 KB | 11.1 KB | -0.1 KB |
| pgdog::frontend (other) | 10.2 KB | 9.9 KB | -0.2 KB |
| jemalloc | 9.8 KB | 9.8 KB | +0.0 KB |
| aws-lc (TLS crypto) | 9.8 KB | 9.8 KB | +0.0 KB |
| everything else | 39.2 KB | 39.4 KB | +0.2 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.4 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.4 KB | -0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.1 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 4.0 KB | +0.1 KB |
</details>
<details><summary>lb flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...).
</details>
<details><summary>microbench flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...).
</details>
<details><summary>pooler flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...).
</details>
<details><summary>sharding-w2 flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...).
</details>
<details><summary>sharding-w8 flamegraph vs 0eda9a90</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-17-other-usu/e0a6ffe0e095c11e...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-17-...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-17-...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-17-...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-17-...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-17-...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-17-...)
</details>
Compared e0a6ffe0 with 0eda9a90 on m7a.metal-48xl (spot).
view thread (38+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2058-c6980583021@github.com>
Permalink: ../gh-pgdogdev-pgdog-2058-c6980583021@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox