pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: levkk (@levkk) <noreply+levkk@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2058: feat(resharding): add initial setup for resumable resharding tasks
Date: Wed, 18 Nov 2026 18:29:09 +0000
Message-ID: <gh-pgdogdev-pgdog-2058-c6987771958@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2058@github.com>
References: <gh-pgdogdev-pgdog-2058@github.com>

I think this is a fine first draft, but there are a lot of Claude-isms in here which we should start pushing back on. I think you can achieve a similar outcome in a lot less code.

I'm not entirely sold on the `pgdog.resharding` table as an architectural choice as well. I get that you can write to it transactionally, but it's not clear to me, yet, if that's strictly necessary. For example, if a table contains data and a record for the `COPY_DATA` task doesn't exist in whatever store, you can assume the copy for that table succeeded, since `COPY` runs inside a transaction itself.

I think it's also totally legitimate to mark that table copy as failed if we don't have a record of it.

This is something I would want for us to integrate with the control plane short term, since it will be used to track and control this operation ultimately.

view thread (38+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2058-c6987771958@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2058-c6987771958@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox